Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement plan read only mode #918

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Implement plan read only mode #918

merged 5 commits into from
Oct 10, 2023

Conversation

AaronPlave
Copy link
Contributor

@AaronPlave AaronPlave commented Oct 3, 2023

To test, set planReadOnly to true in plan.ts store. This writable store can/will be used when entering plan snapshot preview mode which depends on #913

Closes #879

@AaronPlave AaronPlave marked this pull request as ready for review October 3, 2023 23:55
@AaronPlave AaronPlave requested a review from a team as a code owner October 3, 2023 23:55
@AaronPlave AaronPlave requested review from jeffpamer and duranb October 3, 2023 23:55
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure if this is related to this PR's work, but I'm noticing that a multiple tooltips are showing for scheduling goals
Screenshot 2023-10-05 at 12 29 40 PM

@AaronPlave
Copy link
Contributor Author

@duranb resolved tooltip issue and set planReadOnly back to false.

Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AaronPlave AaronPlave temporarily deployed to test-workflow October 10, 2023 00:59 — with GitHub Actions Inactive
Copy link
Collaborator

@duranb duranb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go again!

@AaronPlave AaronPlave merged commit 9f3976c into develop Oct 10, 2023
4 checks passed
@AaronPlave AaronPlave deleted the feat/879/plan-read-only branch October 10, 2023 01:21
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
* Implement plan read only mode
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* Implement plan read only mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plan readonly mode
2 participants