Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to react to action/function permissions #902

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Sep 25, 2023

resolves #860

This one is a pretty big one to test out. On top of making sure that everything still works as it currently does, one ideally would test that the new checks mentioned here (expand the blue boxes to see full list) work as expected.

An example for testing would be:

  1. Create a plan with a certain user
  2. Go into the plan_collaborators table in hasura
  3. Insert a new row containing the id of the plan you created in step 1 and add a different user id from the one you used to create said plan
  4. Add some activities to the plan and verify that you can still run a simulation
  5. Now go to the user_role_permissions table
  6. Edit the user row by changing the simulate value under the action_permissions column to "PLAN_OWNER"
  7. Log out and log back in as the user id of the collaborator you inserted in step 3 and switch to the user role
  8. Navigate to the plan and add a new activity
  9. Verify that you are no longer able to run a simulation

@duranb duranb requested a review from a team as a code owner September 25, 2023 22:03
@duranb duranb temporarily deployed to test-workflow September 25, 2023 23:35 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow September 26, 2023 00:34 — with GitHub Actions Inactive
@AaronPlave
Copy link
Contributor

Tested the first case successfully, will try going through some of the other cases.

@duranb duranb force-pushed the feature/dynamic-function-permissions branch from e586df7 to e154479 Compare October 2, 2023 19:18
@duranb duranb force-pushed the feature/dynamic-function-permissions branch from e154479 to b4aa361 Compare October 9, 2023 17:08
@duranb duranb temporarily deployed to test-workflow October 9, 2023 17:08 — with GitHub Actions Inactive
@duranb duranb force-pushed the feature/dynamic-function-permissions branch from b4aa361 to 3668069 Compare October 9, 2023 23:09
@duranb duranb temporarily deployed to test-workflow October 9, 2023 23:09 — with GitHub Actions Inactive
@duranb duranb force-pushed the feature/dynamic-function-permissions branch from 3668069 to da16762 Compare October 10, 2023 23:09
@duranb duranb temporarily deployed to test-workflow October 10, 2023 23:30 — with GitHub Actions Inactive
@duranb duranb merged commit ddd85a0 into develop Oct 10, 2023
4 checks passed
@duranb duranb deleted the feature/dynamic-function-permissions branch October 10, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI does not react to Action/Function permissions
2 participants