-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to react to action/function permissions #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duranb
had a problem deploying
to
test-workflow
September 25, 2023 22:03 — with
GitHub Actions
Failure
duranb
temporarily deployed
to
test-workflow
September 25, 2023 23:35 — with
GitHub Actions
Inactive
duranb
temporarily deployed
to
test-workflow
September 26, 2023 00:34 — with
GitHub Actions
Inactive
Tested the first case successfully, will try going through some of the other cases. |
duranb
force-pushed
the
feature/dynamic-function-permissions
branch
from
October 2, 2023 19:18
e586df7
to
e154479
Compare
duranb
force-pushed
the
feature/dynamic-function-permissions
branch
from
October 9, 2023 17:08
e154479
to
b4aa361
Compare
duranb
force-pushed
the
feature/dynamic-function-permissions
branch
from
October 9, 2023 23:09
b4aa361
to
3668069
Compare
AaronPlave
approved these changes
Oct 10, 2023
duranb
force-pushed
the
feature/dynamic-function-permissions
branch
from
October 10, 2023 23:09
3668069
to
da16762
Compare
duranb
had a problem deploying
to
test-workflow
October 10, 2023 23:09 — with
GitHub Actions
Failure
duranb
had a problem deploying
to
test-workflow
October 10, 2023 23:10 — with
GitHub Actions
Failure
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #860
This one is a pretty big one to test out. On top of making sure that everything still works as it currently does, one ideally would test that the new checks mentioned here (expand the blue boxes to see full list) work as expected.
An example for testing would be:
user
row by changing thesimulate
value under theaction_permissions
column to"PLAN_OWNER"
user
role