Custom Worker - Warning when use of identifiers. #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
|
Sounds like a reasonable approach to me. We can't currently statically determine that an activity's parameters will be within the allowed range for the command. Related question - what happens if an activity argument turns out to be out of range for the given command? Will the service still produce SEQ JSON, or will it abort with an error? |
goetzrrGit
force-pushed
the
identifier_in_customworker
branch
from
c6fb4a5 to
e26ca10
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
reviewed
Sep 19, 2023
|
@mattdailis The service will still produce a SeqJson file. It will just fail downstream at the seqgen level as seqgen will say the values is out of range. |
goetzrrGit
force-pushed
the
identifier_in_customworker
branch
from
e26ca10 to
4a91f68
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
approved these changes
Sep 21, 2023
…f variables. ex. let temp = 100 C.PREHEAT_OVEN(temp) #ERROR now C.PREHEAT_OVEN(temp) #warning
goetzrrGit
force-pushed
the
identifier_in_customworker
branch
from
4a91f68 to
8baa494
Compare
goetzrrGit
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
Fix the bug where the custom worker will throw an error for the use of variables. ex. let temp = 100 C.PREHEAT_OVEN(temp) #ERROR now C.PREHEAT_OVEN(temp) #warning
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
Fix the bug where the custom worker will throw an error for the use of variables. ex. let temp = 100 C.PREHEAT_OVEN(temp) #ERROR now C.PREHEAT_OVEN(temp) #warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #897
During expansion logic, I observed that when the user attempts to utilize the activity's parameters as command arguments, the custom worker throws an error. This occurs because it endeavors to assess the value of the parameters, which haven't been defined yet.
Unfortunately, the custom worker lacks the capability to evaluate identifiers without compiling the user code at runtime, which is not a viable option.
To address this, I have implemented a warning in case this situation arises.
ex.
previous
now