Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge DB Gateway Changes #72

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Merge DB Gateway Changes #72

merged 2 commits into from
Apr 15, 2024

Conversation

Mythicaeda
Copy link
Contributor

Sister PR to the Aerie repo DB changes. Adds schema qualifiers to all SQL statements and updates the envvars. Tested via using this branch while developing and testing the DB Changes.

@Mythicaeda Mythicaeda added refactor A code change that neither fixes a bug nor adds a feature breaking change A change that will require updating downstream code labels Mar 21, 2024
@Mythicaeda Mythicaeda requested review from a team as code owners March 21, 2024 17:48
@Mythicaeda Mythicaeda self-assigned this Mar 21, 2024
@Mythicaeda Mythicaeda requested a review from skovati March 21, 2024 17:48
Copy link
Contributor

@skovati skovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and works flawlessly alongside the main DB merge aerie branch

docs/ENVIRONMENT.md Outdated Show resolved Hide resolved
- Write to Permissions schema instead of Metadata
- Rename envvars to reflect DB Merge Changes (Breaking)
- Point at `aerie` instead of `aerie_merlin`
- Remove unneeded variable in `parseArray`
@Mythicaeda Mythicaeda merged commit a03842d into develop Apr 15, 2024
4 checks passed
@Mythicaeda Mythicaeda deleted the refactor/merge-dbs branch April 15, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A change that will require updating downstream code refactor A code change that neither fixes a bug nor adds a feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants