Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commands for plan collaborators #85

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Add commands for plan collaborators #85

merged 4 commits into from
Oct 10, 2023

Conversation

cartermak
Copy link
Member

@cartermak cartermak commented Sep 30, 2023 •
edited
Loading

Adds sub-commands to plans to create/list/delete plan collaborators, along with implementing the relevant queries in AerieClient.

Implements integration test cases which required some additions to the integration test infrastructure:

  • I implemented a username override in start_session_from_configuration in order to log in with several usernames, so I added the override to the activate command, as well
  • Removed unused imports across the integration tests while I was updating import statements
  • Updated a few names and (hopefully) cleared up conftest.py

Closes #84

@cartermak cartermak added the enhancement New/improved features and capabilities label Sep 30, 2023
@cartermak cartermak self-assigned this Sep 30, 2023
@cartermak cartermak had a problem deploying to integration-test-workflow September 30, 2023 23:08 — with GitHub Actions Failure
@cartermak cartermak had a problem deploying to integration-test-workflow September 30, 2023 23:08 — with GitHub Actions Error
@cartermak cartermak had a problem deploying to integration-test-workflow September 30, 2023 23:08 — with GitHub Actions Failure
@cartermak cartermak had a problem deploying to integration-test-workflow September 30, 2023 23:08 — with GitHub Actions Failure
@cartermak cartermak had a problem deploying to integration-test-workflow September 30, 2023 23:08 — with GitHub Actions Failure
@cartermak cartermak temporarily deployed to integration-test-workflow September 30, 2023 23:08 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 30, 2023 23:08 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 30, 2023 23:08 — with GitHub Actions Inactive
@cartermak cartermak had a problem deploying to integration-test-workflow October 2, 2023 15:48 — with GitHub Actions Error
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 15:48 — with GitHub Actions Inactive
@cartermak cartermak had a problem deploying to integration-test-workflow October 2, 2023 15:49 — with GitHub Actions Failure
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 15:49 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 15:49 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 15:49 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 15:49 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 15:49 — with GitHub Actions Inactive
@cartermak cartermak had a problem deploying to integration-test-workflow October 2, 2023 16:30 — with GitHub Actions Failure
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 16:30 — with GitHub Actions Inactive
@cartermak cartermak had a problem deploying to integration-test-workflow October 2, 2023 16:31 — with GitHub Actions Failure
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 16:31 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 16:31 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 16:31 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 16:31 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 16:31 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 18:14 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 18:14 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 18:14 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 18:14 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 18:14 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 18:14 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 18:14 — with GitHub Actions Inactive
@cartermak cartermak force-pushed the feature--collaborators branch from c0e4bfc to 53bffa3 Compare October 2, 2023 19:07
@cartermak cartermak had a problem deploying to integration-test-workflow October 2, 2023 19:07 — with GitHub Actions Error
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 19:07 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 19:07 — with GitHub Actions Inactive
@cartermak cartermak had a problem deploying to integration-test-workflow October 2, 2023 19:07 — with GitHub Actions Failure
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 19:07 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 19:07 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 19:07 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 19:07 — with GitHub Actions Inactive
@cartermak cartermak force-pushed the feature--collaborators branch from 53bffa3 to 9ba1f4d Compare October 2, 2023 19:15
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 19:15 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 19:15 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 19:15 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 19:15 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 19:15 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 19:15 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 19:15 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow October 2, 2023 19:15 — with GitHub Actions Inactive
@cartermak cartermak merged commit d83e67d into develop Oct 10, 2023
8 checks passed
@cartermak cartermak deleted the feature--collaborators branch October 10, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mythicaeda Mythicaeda Mythicaeda approved these changes

@Navarro-Jonathan Navarro-Jonathan Awaiting requested review from Navarro-Jonathan

Assignees

@cartermak cartermak

Labels
enhancement New/improved features and capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add commands/queries to edit plan collaborators
2 participants
@cartermak @Mythicaeda