Remove duplicate browse channel list #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting TV playback, either from a recording or live, a list of all channels is created that can be used to select another channel with the up/down keys while watching. This channel list is created twice; as the name implies one for all channels and one for all visible channels. However, both lists are identical and contain all channels. The check on visible or not was already been done somewhere else in the code. Therefore only one list with all channels is needed. Note that the time to create this list can be significant when there are a large number of channels. With satellites and especially with IPTV the number of channels can easily become very large, as in several thousands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting TV playback, either from a recording or live, a list of all channels is created that can be used to select another channel with the up/down keys while watching.
This channel list is created twice; as the name implies one for all channels and one for all visible channels. However, both lists are identical and contain all channels. The check on visible or not was already been done somewhere else in the code.
Therefore only one list with all channels is needed. Note that the time to create this list can be significant when there are a large number of channels. With satellites and especially with IPTV the number of channels can easily become very large, as in several thousands.