Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Added support for generating bytecode disassembly #20654

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

awelc
Copy link
Contributor

@awelc awelc commented Dec 17, 2024

Description

This PR adds support for generating bytecode disassembly (and depositing it in the build directory) whenever a user runst tests with tracing enabled. The main reason is to to enable bytecode-level debugging in the Trace Viewer. This is particularly important due to discrepancy between source code and bytecode and resulting complications in mapping recorded trace events to source code (e.g., some variables and lines of code are optimized away). Providing the ability to switch to the bytecode view can provide necessary clarification in such cases and this PR is the first step to delivering this functionality.

Test plan

All tests must pass. Verified manually that disassembled bytecode is generated correctly

@awelc awelc self-assigned this Dec 17, 2024
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 4:42pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 4:42pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 4:42pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 4:42pm

@awelc awelc requested a review from tzakian December 17, 2024 12:33
@awelc awelc temporarily deployed to sui-typescript-aws-kms-test-env December 17, 2024 12:33 — with GitHub Actions Inactive
@awelc awelc marked this pull request as draft December 19, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant