Format missing module errors in upgrade errors #20541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
reviewed
Dec 9, 2024
jordanjennings-mysten
force-pushed
the
missing-module-error-formatting
branch
from
870cc60 to
a35cfa0
Compare
jordanjennings-mysten
had a problem deploying
to
sui-typescript-aws-kms-test-env
GitHub Actions
Failure
jordanjennings-mysten
had a problem deploying
to
sui-typescript-aws-kms-test-env
GitHub Actions
Failure
amnn
reviewed
Dec 10, 2024
There was a problem hiding this comment.
I'm pretty happy with this change, modulo the question about trying to avoid returning an Err(...) instead of the diagnostic. It would be good to get @tnowacki's take on things, because he's more the expert in this area than me, but after that, I think this is good to go!
Comment on lines
832
to
838
| let toml_path = package_path.join("Move.toml"); | ||
| let toml_str = fs::read_to_string(&toml_path).context("Unable to read Move.toml")?; | ||
| let hash = FileHash::new(&toml_str); | ||
|
|
||
| let start: usize = toml_str | ||
| .find(PACKAGE_TABLE) | ||
| .context("Malformed Move.toml")?; |
There was a problem hiding this comment.
It looks like if we fail to read the Move.toml we may end up hiding all the other diagnostics. Do you think it would be possible for us to always produce some kind of Diagnostics value, even if we failed to read the Move.toml to avoid that?
There was a problem hiding this comment.
I was thinking this more as a "critical" error since a build shouldn't be possible however I think it could be good to just let this return a diagnostic for byte ranges 0,0 as a fallback. Some errors I'd guess will just fall in that "critical" category and should be errored out but we could potentially discuss follow up work to prevent errors from stopping execution by converting Errors -> Diags. Or alternatively just maintain a list of errors and print them last / concatenate them into a single error that is thrown last.
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
missing-module-error-formatting
branch
from
cec243e to
a1bd394
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
missing-module-error-formatting
branch
from
a1bd394 to
ae1dbf7
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
missing-module-error-formatting
branch
from
ae1dbf7 to
3a63f78
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tnowacki
reviewed
Dec 18, 2024
...ests/snapshots/sui__upgrade_compatibility__upgrade_compatibility_tests__addresses_first.snap
Show resolved
Hide resolved
...snapshots/sui__upgrade_compatibility__upgrade_compatibility_tests__declarations_missing.snap
Show resolved
Hide resolved
...src/unit_tests/snapshots/sui__upgrade_compatibility__upgrade_compatibility_tests__emoji.snap
Outdated
Show resolved
Hide resolved
jordanjennings-mysten
force-pushed
the
missing-module-error-formatting
branch
from
3a63f78 to
75782c9
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tnowacki
approved these changes
Dec 19, 2024
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
missing-module-error-formatting
branch
from
b492ced to
783feae
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
missing-module-error-formatting
branch
from
783feae to
5400241
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
merged commit f321519
into
MystenLabs:main
49 of 50 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Missing modules errors do not have a file to point to since their file has been removed during upgrade or otherwise unknown since the declaration is gone from its previous file if the file still exists. Align missing modules errors with the behavior of other errors by using Move.toml as the reference point for these errors and pointing to the "package" instead.
Test plan
snapshots
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.