-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
indexer alt restorer: init commit and restore object infos #20507
Merged
+437
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 4, 2024 20:29 — with
GitHub Actions
Inactive
gegaowp
requested review from
a team,
amnn,
wlmyng,
stefan-mysten,
emmazzz and
suiwombat
as code owners
December 4, 2024 20:30
gegaowp
requested review from
pchrysochoidis and
mystieanwaya
and removed request for
a team
December 4, 2024 20:30
gegaowp
force-pushed
the
idx-restore-reuse
branch
from
December 4, 2024 20:31
11402ef
to
294e3ee
Compare
gegaowp
force-pushed
the
indexer-restore-init
branch
from
December 4, 2024 20:32
fdbecad
to
a06e76e
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 4, 2024 20:32 — with
GitHub Actions
Inactive
gegaowp
requested review from
lxfind and
bmwill
and removed request for
a team,
stefan-mysten,
suiwombat,
pchrysochoidis and
mystieanwaya
December 4, 2024 20:33
gegaowp
force-pushed
the
indexer-restore-init
branch
from
December 4, 2024 20:40
a06e76e
to
4981347
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 18, 2024 21:15 — with
GitHub Actions
Inactive
gegaowp
requested review from
amnn
and removed request for
akichidis,
asonnino,
joyqvq,
kchalkias,
ronny-mysten and
mystenmark
December 18, 2024 21:16
amnn
approved these changes
Dec 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can still get rid of the kv_genesis
logic, and there's a small simplification for the inner loop over live objects, but this is much easier to follow now, thanks @gegaowp ! Good to go 🚀
gegaowp
force-pushed
the
indexer-restore-init
branch
from
December 23, 2024 16:25
789993d
to
8f0c8e0
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 23, 2024 16:26 — with
GitHub Actions
Inactive
gegaowp
force-pushed
the
indexer-restore-init
branch
from
December 23, 2024 16:46
8f0c8e0
to
c897af4
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 23, 2024 16:46 — with
GitHub Actions
Inactive
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 23, 2024 18:08 — with
GitHub Actions
Inactive
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 23, 2024 18:44 — with
GitHub Actions
Inactive
gegaowp
changed the title
indexer restorer: init commit and restore object infos
indexer alt restorer: init commit and restore object infos
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
title, the main parts are:
Test plan
local run
it's worth doing some data integrity check eventually and not done yet.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.