[dapp-kit] mark vanilla-extract libraries as dev dependencies #20307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
williamrobertson13
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Jordan-Mysten
approved these changes
Nov 18, 2024
hayes-mysten
approved these changes
Nov 18, 2024
williamrobertson13
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
8 tasks
williamrobertson13
added a commit
that referenced
this pull request
Nov 18, 2024
## Description Reverts #20307. This change oddly worked when I was testing locally and applying a pnpm patch to dapp-kit, but it looks like the build config needs tweaked because vanilla-extract is still ending up as an end user dependency which isn't good since that's the whole reason we decided to use vanilla-extract 😅. I'm going to revert this for now, and I'll see how I can fix this properly sometime later this week. <img width="844" alt="image" src="https://github.com/user-attachments/assets/0d042c6e-e08b-4daa-8e4c-f2cbed41c517"> ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Potentially addresses #20294. The vanilla-extract libraries are internal dependencies as we ship the library with raw CSS files.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.