Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[move][std] Add std::uq64_64 #19894

Merged
merged 12 commits into from
Dec 6, 2024
Merged

[move][std] Add std::uq64_64 #19894

merged 12 commits into from
Dec 6, 2024

Conversation

tnowacki
Copy link
Contributor

@tnowacki tnowacki commented Oct 17, 2024 •
edited
Loading

Description

Test plan

  • New tests

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI: New Move module std::uq64_64 for larger-precision, fixed-point numbers
  • Rust SDK:
  • REST API:

@tnowacki tnowacki requested a review from a team October 17, 2024 18:51
@vercel Vercel
Copy link

vercel bot commented Oct 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 10:16pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 10:16pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 10:16pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 10:16pm

jonas-lj
jonas-lj approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@jonas-lj jonas-lj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The macros are very cool. I've just added some suggestions for the comments and docs, but everything else looks fine.

crates/sui-framework/packages/move-stdlib/sources/macros.move Outdated Show resolved Hide resolved
crates/sui-framework/packages/move-stdlib/sources/macros.move Outdated Show resolved Hide resolved
crates/sui-framework/packages/move-stdlib/sources/macros.move Outdated Show resolved Hide resolved
crates/sui-framework/packages/move-stdlib/sources/uq64_64.move Outdated Show resolved Hide resolved
crates/sui-framework/packages/move-stdlib/sources/macros.move Show resolved Hide resolved
crates/sui-framework/packages/move-stdlib/sources/uq32_32.move Outdated Show resolved Hide resolved
@tnowacki tnowacki temporarily deployed to sui-typescript-aws-kms-test-env December 6, 2024 19:24 — with GitHub Actions Inactive
@tnowacki tnowacki temporarily deployed to sui-typescript-aws-kms-test-env December 6, 2024 19:38 — with GitHub Actions Inactive
@tnowacki tnowacki temporarily deployed to sui-typescript-aws-kms-test-env December 6, 2024 21:08 — with GitHub Actions Inactive
@tnowacki tnowacki mentioned this pull request Dec 6, 2024
Merged
8 tasks
@tnowacki tnowacki requested a review from mystenmark as a code owner December 6, 2024 21:46
@tnowacki tnowacki temporarily deployed to sui-typescript-aws-kms-test-env December 6, 2024 21:46 — with GitHub Actions Inactive
@tnowacki tnowacki enabled auto-merge (squash) December 6, 2024 21:57
cgswords
cgswords approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@cgswords cgswords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tnowacki tnowacki temporarily deployed to sui-typescript-aws-kms-test-env December 6, 2024 22:15 — with GitHub Actions Inactive
@tnowacki tnowacki merged commit 705e7b2 into MystenLabs:main Dec 6, 2024
48 checks passed
@tnowacki tnowacki deleted the uq64_64 branch December 6, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlwuest karlwuest karlwuest left review comments

@jonas-lj jonas-lj jonas-lj approved these changes

@cgswords cgswords cgswords approved these changes

@mystenmark mystenmark Awaiting requested review from mystenmark mystenmark is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tnowacki @cgswords @karlwuest @jonas-lj