add default aes to keystore.. #17384
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
hi - thanks for the PR, wondering what's the context and what do you plan to use AES encryption/decryption for in the context of sui? |
|
there are some cases, we don't want to display the base64 directly in the files, [not security enough], by add the default aes-encode, developers can compile the bin files with their own encrypto password, so instead of save base64 content , I think aes-encode content with user-custom aes-128 result is more reasonble. in fact, similar cases exist in the config files, network.yaml, fullnode.yaml, all the key-pair currently only save as base-64, but key-pairs content is less used in normal developer, but cli-key tool is widly use for dapps develoers in their server for deploy dapps. |
i generally like the direction but there are few details that worth going through standardization. Do you want to submit to SIP as well? It will be a greats place to elaborate the motivation, test plans and some choices around prefix etc for the broader community for feedback. thanks for the contribution! |
|
in fact I have code already change the config and yaml files, but with more changes to nodeConfig Struct, I was thinking make 2 merge to fix these. Your comment of making a SIP is quite good, So I try one , sui-foundation/sips#21, |
|
Yes, there was a relate merge in sui project, #17384, the develop suggest me to submit a sip |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.