-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: cleanup app.rs #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parsing functions can be removed in favor of directly using parse().unwrap_or_default()
There's interval: u64
on L494 that can also be cleaned up of its data type
Contributes to #3 |
I was thinking of this rather let interval: u64 = (hr * 3600000) + (min * 60000) + (sec * 1000) + ms; Let's leave that |
yeah that works too |
Done |
Thanks! |
Refactor
unwrap_or_default()
for parsing ofString
tou64
/f64