Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make entity dump filename windows compatible #5145

Merged
merged 2 commits into from
Oct 18, 2023
Merged

fix: make entity dump filename windows compatible #5145

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4790c44
fix: make entity dump filename windows compatible
jdrueckert Sep 28, 2023
fd7cbb2
Merge branch 'develop' into fix/windows-compatible-entity-dump-filename
jdrueckert Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engine/src/main/java/org/terasology/engine/logic/console/commands/CoreCommands.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ public String dumpEntities(@CommandParam(value = "componentNames", required = fa
PrefabSerializer prefabSerializer =
new PrefabSerializer(engineEntityManager.getComponentLibrary(), engineEntityManager.getTypeSerializerLibrary());
WorldDumper worldDumper = new WorldDumper(engineEntityManager, prefabSerializer);
Path outFile = PathManager.getInstance().getHomePath().resolve(Instant.now() + "-entityDump.json");
Path outFile = PathManager.getInstance().getHomePath().resolve(Instant.now().toString().replaceAll(":", "-") + "-entityDump.json");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it not be cleaner to use the iso-8601 basic format in general, and not the extended format? see:
https://stackoverflow.com/questions/27725408/alternative-to-colon-in-a-time-format

if (componentNames.length == 0) {
savedEntityCount = worldDumper.save(outFile);
} else {
Expand Down
Loading