Bugfix: Resizing masks containing over 65,535 cells not supported by OpenCV #938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #937
When Cellpose detect over 65,535 it casts the masks vector to
uint32
. However, this format is not natively supported by OpenCV, causing itsresize
function to crash. See issue #937 for more information.This PR proposes to use float32 instead, which is supported by OpenCV, and includes the following changes
uint32
, first cast tofloat32
, resize usingcv2
, round and cast resulting matrix touint32
.float32
happensThis PR also considers three implications:
uint16
and the proposed approach which casts tofloat32
yield identical results.Reproducible examples