Upgrade to compose 1.6.0-beta01 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedRejeb
requested changes
Jan 28, 2024
richeditor-compose/src/commonMain/kotlin/com/mohamedrejeb/richeditor/ui/BasicRichTextEditor.kt
Outdated
Show resolved
Hide resolved
MohamedRejeb
approved these changes
Jan 29, 2024
|
@MohamedRejeb can you do an alpha/dev build release to maven with this change? I was hoping the new compose dev build today would include the change where they fixed the backwards compat method call upstream for textalign, but it seems it didn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if you want to take this right away since it is still in Beta, but this fixes a critical bug in input handling.
In the 1.5.x branch,
InteractionSourceonly ever emit one event, which makes listening for press and release events impossible.