Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openAppSettings on iOS 18 #183

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

cvb941
Copy link
Contributor

@cvb941 cvb941 commented Sep 30, 2024

On iOS 18, openAppSettings() for notifications fails with:

BUG IN CLIENT OF UIKIT: The caller of UIApplication.openURL(_:) needs to migrate to the non-deprecated UIApplication.open(_:options:completionHandler:). Force returning false (NO).

Here is a relevant apple thread: https://forums.developer.apple.com/forums/thread/763568

This PR fixes the issue.

Copy link
Owner

@MohamedRejeb MohamedRejeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@MohamedRejeb MohamedRejeb merged commit acb2a73 into MohamedRejeb:main Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants