Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package Builder Fails Under Ubuntu 18.04 #31

Open
Darksaint08 opened this issue Oct 27, 2018 · 2 comments · May be fixed by #37
Open

Package Builder Fails Under Ubuntu 18.04 #31

Darksaint08 opened this issue Oct 27, 2018 · 2 comments · May be fixed by #37

Comments

@Darksaint08
Copy link

Darksaint08 commented Oct 27, 2018 •
edited
Loading

I tried to build the deb again and this line appears to break the build as it now returns nothing:

USER=`who | grep ':0' | grep -o '^\w*' | head -n1`

when this runs the USER variable remains empty which causes the package build to fail.

I modified mine to just set

USER=<My_UserName>

Which got it to work for me and I was able to install. See issue #28 for help with starting the service in 18.x by the way.
@voglster
Copy link

for my machine USER=who | grep ':1' | grep -o '^\w*' | head -n1 results in the user as well

note the :1 not the :0

mvastola added a commit to mvastola/LogiGSK that referenced this issue Feb 1, 2021
@mvastola
Remove autostart from debian postinstall trigger
6398705 
There is no reliable way to determine which user(s) the service should
start for, so don't try to guess: just show instructions to do it
manually.

Fixes MohamadSaada#31
@mvastola
Copy link

mvastola commented Feb 1, 2021

The :0 or :1 depends on which display you're using and is not a good way to do this at all because a computer may have multiple displays running or the user logged into the display might not be the user you're trying to install this for.

If you were dead-set on using the USER thing here, the better way would have been

USER="$(who -m | cut -f1 -d' ' )"

Really though, there's no reliable way to guess who this should be installed for. It should be done manually. I'm submitting a quick PR now to fix this.

@mvastola mvastola linked a pull request Feb 1, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove autostart from debian postinstall trigger mvastola/LogiGSK
3 participants
@mvastola @voglster @Darksaint08