-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BOP-1572] Add etcd configuration and custom flag migration info #243
base: main
Are you sure you want to change the base?
Conversation
content/docs/migrate-from-MKE-3.md
Outdated
MKE 3 configuration file: | ||
``` | ||
[cluster_config.custom_kube_api_server_flags] = ["--enable-garbage-collector=false"] | ||
``` | ||
|
||
MKE 4 configuration file: | ||
``` | ||
spec: | ||
apiServer: | ||
extraArgs: | ||
enable-garbage-collector: false | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MKE 3 configuration file: | |
``` | |
[cluster_config.custom_kube_api_server_flags] = ["--enable-garbage-collector=false"] | |
``` | |
MKE 4 configuration file: | |
``` | |
spec: | |
apiServer: | |
extraArgs: | |
enable-garbage-collector: false | |
``` | |
- MKE 3 configuration file: | |
[cluster_config.custom_kube_api_server_flags] = ["--enable-garbage-collector=false"]
- MKE 4 configuration file:
spec:
apiServer:
extraArgs:
enable-garbage-collector: false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure that accepting the suggestion will result in a correct rendering, so I will try to offer here how I would like to see this example present.
-
MKE 3 configuration file:
[cluster_config.custom_kube_api_server_flags] = ["--enable-garbage-collector=false"]
-
MKE 4 configuration file:
spec apiServer: extraArgs: enable-garbage-collector: false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to match this by bullet pointing the config examples.
Co-authored-by: Kory <[email protected]>
Co-authored-by: Kory <[email protected]>
Co-authored-by: Kory <[email protected]>
@KoryKessel-Mirantis As discussed, I based the etcd pag on the existing MKE 3 docs, just changing the text to match the MKE 4 config and featureset. The other sections (defrag/cleaning/alarm) describe features not yet implemented in MKE 4. |
This change adds: