Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOP-1572] Add etcd configuration and custom flag migration info #243

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nsteph
Copy link
Collaborator

@nsteph nsteph commented Nov 23, 2024

This change adds:

  • etcd configuration page (similar to other Kube components)
  • subsections on the MKE 3 configuration migration docs that cover kubernetes custom flags and kubelet custom flag profiles

@nsteph nsteph requested a review from a team as a code owner November 23, 2024 22:01
content/docs/migrate-from-MKE-3.md Outdated Show resolved Hide resolved
Comment on lines 106 to 117
MKE 3 configuration file:
```
[cluster_config.custom_kube_api_server_flags] = ["--enable-garbage-collector=false"]
```

MKE 4 configuration file:
```
spec:
apiServer:
extraArgs:
enable-garbage-collector: false
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MKE 3 configuration file:
```
[cluster_config.custom_kube_api_server_flags] = ["--enable-garbage-collector=false"]
```
MKE 4 configuration file:
```
spec:
apiServer:
extraArgs:
enable-garbage-collector: false
```
- MKE 3 configuration file:

[cluster_config.custom_kube_api_server_flags] = ["--enable-garbage-collector=false"]


- MKE 4 configuration file:

spec:
apiServer:
extraArgs:
enable-garbage-collector: false

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that accepting the suggestion will result in a correct rendering, so I will try to offer here how I would like to see this example present.

  • MKE 3 configuration file:

    [cluster_config.custom_kube_api_server_flags] = ["--enable-garbage-collector=false"]
    
  • MKE 4 configuration file:

    spec
      apiServer:
        extraArgs:
          enable-garbage-collector: false
    

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to match this by bullet pointing the config examples.

content/docs/migrate-from-MKE-3.md Outdated Show resolved Hide resolved
@nsteph
Copy link
Collaborator Author

nsteph commented Dec 11, 2024

@KoryKessel-Mirantis As discussed, I based the etcd pag on the existing MKE 3 docs, just changing the text to match the MKE 4 config and featureset.

The other sections (defrag/cleaning/alarm) describe features not yet implemented in MKE 4.

@KoryKessel-Mirantis KoryKessel-Mirantis self-assigned this Dec 17, 2024
@KoryKessel-Mirantis KoryKessel-Mirantis added this to the 4.0.1 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants