You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated Packages Several packages such as @lerna/package, @lerna/project, and @lerna/validation-error are marked as deprecated. Using deprecated packages can lead to future compatibility issues and lack of support. Consider finding alternatives or updating to supported versions.
Engine Restrictions Some packages like @testing-library/dom and its dependencies specify engine versions that could restrict compatibility with certain Node.js versions. Ensure that these engine versions align with your project's Node.js environment to avoid runtime issues.
Peer Dependencies Multiple packages such as write-json-file and its dependencies have been added with peer: true. This could potentially lead to unmet peer dependency issues if the peer packages are not properly managed in the project.
Remove deprecated package to avoid potential security risks and lack of support
Consider removing the dependency on @lerna/package as it is marked as deprecated. Using deprecated packages can lead to security vulnerabilities and lack of support in the future.
-"node_modules/@lerna/package": {- "version": "6.4.1",- "resolved": "https://registry.npmjs.org/@lerna/package/-/package-6.4.1.tgz",- "integrity": "sha512-TrOah58RnwS9R8d3+WgFFTu5lqgZs7M+e1dvcRga7oSJeKscqpEK57G0xspvF3ycjfXQwRMmEtwPmpkeEVLMzA==",- "deprecated": "Package no longer supported. Contact Support at https://www.npmjs.org/support for more info.",- "dev": true,- "license": "MIT",- "peer": true,- "dependencies": {- "load-json-file": "^6.2.0",- "npm-package-arg": "8.1.1",- "write-pkg": "^4.0.0"- },- "engines": {- "node": "^14.15.0 || >=16.0.0"- }-}+(Remove the entire block related to `@lerna/package`)
Suggestion importance[1-10]: 9
Why: Removing a deprecated package like @lerna/package is crucial to avoid potential security vulnerabilities and ensure future support, making this suggestion highly relevant and important.
9
Maintainability
Remove or replace deprecated package to avoid future compatibility issues
Consider removing or replacing the @lerna/project package as it is marked as deprecated. Continuing to use a deprecated package can lead to future compatibility issues.
-"node_modules/@lerna/project": {- "version": "6.4.1",- "resolved": "https://registry.npmjs.org/@lerna/project/-/project-6.4.1.tgz",- "integrity": "sha512-BPFYr4A0mNZ2jZymlcwwh7PfIC+I6r52xgGtJ4KIrIOB6mVKo9u30dgYJbUQxmSuMRTOnX7PJZttQQzSda4gEg==",- "deprecated": "Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.",- "dev": true,- "license": "MIT",- "peer": true,- "dependencies": {- "@lerna/package": "6.4.1",- "@lerna/validation-error": "6.4.1",- "cosmiconfig": "^7.0.0",- "dedent": "^0.7.0",- "dot-prop": "^6.0.1",- "glob-parent": "^5.1.1",- "globby": "^11.0.2",- "js-yaml": "^4.1.0",- "load-json-file": "^6.2.0",- "npmlog": "^6.0.2",- "p-map": "^4.0.0",- "resolve-from": "^5.0.0",- "write-json-file": "^4.3.0"- },- "engines": {- "node": "^14.15.0 || >=16.0.0"- }-}+(Remove the entire block related to `@lerna/project`)
Suggestion importance[1-10]: 9
Why: Removing or replacing deprecated packages like @lerna/project is essential for maintaining codebase health and avoiding future compatibility issues, making this suggestion highly relevant.
9
Best practice
Pin the version of graphql to avoid potential inconsistencies due to unexpected updates
Pin the version of graphql to a specific version rather than using a version range. This can help ensure consistent behavior and compatibility in your application.
Why: Pinning the version of graphql helps prevent unexpected issues due to automatic updates, which is important for maintaining consistent application behavior.
8
Update the Node.js engine version to ensure compatibility with supported versions
Update the node engine version for @testing-library/dom/node_modules/ansi-styles to align with the latest stable Node.js releases, as the current version range may be too broad and include unsupported versions.
Why: Updating the Node.js engine version to a more recent and stable version range is a good practice to ensure compatibility and support, although it is not critical.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bh2smith
requested review from
GAllen98,
marcelokunze,
tifrel,
SurgeCode,
sainthiago,
microchipgnu,
nategeier,
Jxnis and
rubenmarcus
as code owners
mintbase-codium-pr-agent
bot
added
enhancement
User description
Ideally this resolve the missing peer dependency issue experienced in bh2smith/neareth-tunnel#10
Closes #549
PR Type
enhancement, dependencies
Description
graphqlas a direct dependency to resolve missing peer dependency issues.@mintbase-js/sdkfrom version 0.6.2 to 0.6.5 to ensure compatibility and access to new features.package-lock.json.devtodevOptionalto optimize the development environment.Changes walkthrough 📝
package-lock.json
Update dependencies and add `graphql` as a direct dependencypackage-lock.json
graphqlas a direct dependency.@mintbase-js/sdkfrom version 0.6.2 to 0.6.5.devtodevOptional.package.json
Add `graphql` as a direct dependency and update SDKpackages/data/package.json
graphqlas a direct dependency.@mintbase-js/sdkfrom version 0.6.2 to 0.6.5.