Add proof of concept support for HSL lighting #1
Conversation
Add ack and unack set_hsl functions Add mode state (ctl or hsl) Add correct return of state to HA
|
@louisjennings I don't know if dominikberse will answer, i have tried to make some PR some month ago without any answer. How are you running the code ? A Docker on a PI 4 ? |
| @@ -28,8 +28,8 @@ RUN sh ./install-bluez.sh | |||
|
|
|||
| # install bridge | |||
| WORKDIR /opt/hass-ble-mesh | |||
| RUN git clone https://github.com/minims/homeassistant-bluetooth-mesh.git . | |||
| RUN git checkout master | |||
| RUN git clone https://github.com/louisjennings/homeassistant-bluetooth-mesh.git . | |||
There was a problem hiding this comment.
| RUN git clone https://github.com/louisjennings/homeassistant-bluetooth-mesh.git . | |
| RUN git clone https://github.com/minims/homeassistant-bluetooth-mesh.git . |
After merge it will use minims/master
| RUN git clone https://github.com/minims/homeassistant-bluetooth-mesh.git . | ||
| RUN git checkout master | ||
| RUN git clone https://github.com/louisjennings/homeassistant-bluetooth-mesh.git . | ||
| RUN git checkout light-hsl |
There was a problem hiding this comment.
| RUN git checkout light-hsl | |
| RUN git checkout master |
| @@ -1,7 +1,7 @@ | |||
| asyncio-mqtt==0.12.1 | |||
| bitstring==3.1.9 | |||
| black==22.10.0 | |||
| git+https://github.com/minims/python-bluetooth-mesh@43f3b368add0e0a40782478369a30454b95a9034 | |||
| git+https://github.com/louisjennings/python-bluetooth-mesh@dc4132274b0883c9296eab9dd0998a345280e051 | |||
There was a problem hiding this comment.
| git+https://github.com/louisjennings/python-bluetooth-mesh@dc4132274b0883c9296eab9dd0998a345280e051 | |
| git+https://github.com/minims/python-bluetooth-mesh@d813d4860025bf28a7338681229e728feeeed851 |
I have rebase my fork to latest version of the official repo
There was a problem hiding this comment.
The HSL functionality depends upon changes I made in the required commit. I'll eventually try getting the HSL models included in the official repo. Until then, I can create a pull request from the feature branch to your repo.
|
Yes, I agree that it would be good to have a centralised repository for all the changes. If the original is inactive, then your repo would be the next best (my fork is a fork of your repo). I have two instances (dev and production) both are run as docker containers but the production instance's docker host is running inside a VM with a BT adapter passed through. |
|
Ok so we can start by a PR in https://github.com/Minims/python-bluetooth-mesh |
|
An other thing, have you check the branch called imprive-stability ? I wonder if we need to integrate this in the master branch. https://github.com/dominikberse/homeassistant-bluetooth-mesh/tree/feature/improve-stability |
|
@louisjennings so python-bluetooth-mesh is up to date and rebase on SilvairGit/master latest commit to use in requirements is : |
For testing & review