Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction_snark: remove useless discard of warning 67 #16431

Open
wants to merge 1 commit into
base: dw/remove-additional-useless-warning-discard
Choose a base branch
from

Conversation

dannywillems
Copy link
Member

Removing step by step.

Explain your changes:
*

Explain how you tested your changes:
*

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@dannywillems dannywillems requested a review from a team as a code owner December 16, 2024 15:05
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems requested a review from svv232 December 16, 2024 15:06
@dannywillems
Copy link
Member Author

dannywillems commented Dec 16, 2024

It seems that warnings are ignored at the top-level, in dune-project. However, the warning 67 is not raised when this commit is applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant