Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial] Mina_wire_types/test: stop discarding warning #16427

Open
wants to merge 2 commits into
base: dw/run-dune-fmt-on-dune-files
Choose a base branch
from

Conversation

dannywillems
Copy link
Member

It seems it is not even warned while compiling.

Explain your changes:
*

Explain how you tested your changes:
*

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

Revamping an old small PR
It seems it is not even warned while compiling.
@dannywillems dannywillems requested a review from a team as a code owner December 16, 2024 12:44
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems requested a review from svv232 December 16, 2024 12:45
@dannywillems dannywillems changed the title Mina_wire_types/test: stop discarding warning [trivial] Mina_wire_types/test: stop discarding warning Dec 16, 2024
@dannywillems dannywillems force-pushed the dw/run-dune-fmt-on-dune-files branch from 185cf47 to c8b0d61 Compare December 17, 2024 11:24
@dannywillems dannywillems requested review from a team as code owners December 17, 2024 11:24
@dannywillems dannywillems force-pushed the dw/run-dune-fmt-on-dune-files branch 2 times, most recently from 992e2b2 to ea03076 Compare December 18, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants