Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GATT Alert Level Characteristic Support #4

Merged

Conversation

carlos21
Copy link
Member

@carlos21 carlos21 commented Jul 3, 2018

Issue

#1

What does this PR Do?

Added GATT Alert Level Characteristic Support

Where should the reviewer start?

AlertLevelCharacteristicViewController.swift

@carlos21 carlos21 requested a review from colemancda July 3, 2018 01:53
@colemancda
Copy link
Member

@carlos21 resolve conflicts pls


fields = [.level("\(value.rawValue)")]

tableView.register(UINib(nibName: cellIdentifier, bundle: nil), forCellReuseIdentifier: cellIdentifier)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlos21 Are we going to use R.swift?

carlos21 added 2 commits July 3, 2018 09:32
…alert-level

# Conflicts:
#	BluetoothExplorer.xcodeproj/project.pbxproj
#	BluetoothExplorer/Controller/PeripheralCharacteristicDetailViewController.swift
#	BluetoothExplorer/Controller/Protocols/CharacteristicViewController.swift
@carlos21 carlos21 self-assigned this Jul 3, 2018
@carlos21 carlos21 merged commit aba0f03 into feature/gatt-characteristics-screens Jul 3, 2018
@carlos21 carlos21 deleted the feature/add-alert-level branch July 3, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants