#1 addressing feedback

MillerTechnologyPeru · Jun 26, 2018 · c628a95 · c628a95
1 parent 2b4ee9d
commit c628a95
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/...orer/Controller/GATT Characteristic Editors/ModelNumberCharacteristicViewController.swift b/...orer/Controller/GATT Characteristic Editors/ModelNumberCharacteristicViewController.swift
@@ -31,7 +31,7 @@ final class ModelNumberCharacteristicViewController: UIViewController {
 
     // MARK: - Actions
 
-    @IBAction func textFieldEditingChanged(_ sender: Any) {
+    @IBAction func textFieldEditingChanged(_ sender: UITextField) {
 
         guard let text = modelTextField.text
             else { return }
@@ -49,8 +49,9 @@ final class ModelNumberCharacteristicViewController: UIViewController {
         updateText()
     }
 
-    func updateText() {
+    private func updateText() {
 
+        modelTextField.isEnabled = valueDidChange != nil
         modelTextField.text = value.rawValue
     }
 }

diff --git a/...xplorer/Controller/GATT Characteristic Editors/SystemIDCharacteristicViewController.swift b/...xplorer/Controller/GATT Characteristic Editors/SystemIDCharacteristicViewController.swift
@@ -45,9 +45,12 @@ final class SystemIDCharacteristicViewController: UIViewController {
         guard let organizationallyUniqueIdentifier = UInt32(organizationallyUniqueIdentifierText)
             else { return }
 
-        value = GATTSystemID(manufacturerIdentifier: manufacturerIdentifier,
-                             organizationallyUniqueIdentifier: organizationallyUniqueIdentifier)!
-//        valueDidChange?(value)
+        guard let systemID = GATTSystemID(manufacturerIdentifier: manufacturerIdentifier,
+                                          organizationallyUniqueIdentifier: organizationallyUniqueIdentifier)
+            else { return }
+
+        value = systemID
+        valueDidChange?(value)
     }
 }