Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 prevent duplicated ids for headings #1580

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

Saul-Mirone
Copy link
Member

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

Closes: #1567

Prevent duplicated ids for headings

How did you test this change?

CI

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
milkdown-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 3:25pm

Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: feea6f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Dec 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit feea6f6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@Saul-Mirone Saul-Mirone enabled auto-merge (squash) December 9, 2024 15:26
@Saul-Mirone Saul-Mirone merged commit a1f3676 into main Dec 9, 2024
5 checks passed
@Saul-Mirone Saul-Mirone deleted the prevent-duplicated-heading-ids branch December 9, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] outline id conflict
1 participant