Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates dead Microsoft Store link to WMR Collection to next best equivalent #787

Open
wants to merge 2 commits into
base: docs
Choose a base branch
from

Conversation

ErrorRaffyline0
Copy link
Contributor

The old URL has been removed, same with the ?gamecapabilities=VREnabled search filter in the Microsoft Store. https://www.microsoft.com/store/collections/mr-playgamesall is the only thing similar to still exist.

Copy link

@ErrorRaffyline0 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit fce772f:

✅ Validation status: passed

File Status Preview URL Details
enthusiast-guide/index.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.

Copy link
Contributor

@lolambean lolambean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just remove this link entirely. Do not replace with this other games related link.

@ErrorRaffyline0
Copy link
Contributor Author

Please just remove this link entirely. Do not replace with this other games related link.

The proposed URL links to MR games specifically. I'm not sure what you mean by "other games". Is the removal decision part of the deprecation of WMR?

@lolambean
Copy link
Contributor

The original link was related to "best in WMR". You replaced that with a link to games. That is what I meant by "other games link."

This whole section is called "What's New." There is nothing new in WMR and so rather than replace this link, I am suggesting we remove it entirely.

Honestly, we can just remove the whole "What's New" section of this page. As I said, there is nothing new and we don't want to give the impression that there will be anything new.

Make sense?

@ErrorRaffyline0
Copy link
Contributor Author

I understand. I'll remove it.

Copy link
Contributor

Learn Build status updates of commit c2fc69a:

✅ Validation status: passed

File Status Preview URL Details
enthusiast-guide/index.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

PRMerger Results

Issue Description
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.

Copy link
Contributor

@lolambean lolambean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants