Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gedit 3.8 compatibility #9

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jefferyto
Copy link

This updates the code to be compatible with gedit 3.8:

  • Updated .plugin file (with a separate .plugin file for gedit <= 3.6).
  • Fixed empty tab closing on launch. This should also be compatible with gedit <= 3.6, though I haven't tested it yet.

Would be great if this is merged soon as I have some other ideas I'd like to implement after this :-)

@suprafly
Copy link

Thanks for getting this ported. Wondering is you might be able to help me get the gedit-django-project plugin up to gedit 3.8? I've tried, but I haven't used python3 enough to see what I'm missing.

@mrkeyboard
Copy link

Great fix - your port worked wonderfully on gedit 3.8.3, Ubuntu 13.10

@jefferyto
Copy link
Author

@suprafly I'm a little low on free time lately, but I'll try to take a look at that plugin soon. If you post your work-in-progress (as a branch in your fork) and describe the error(s) you're seeing (as an issue, again in your fork), I might be able to help.

@mrkeyboard Thanks!

@suprafly
Copy link

suprafly commented Feb 3, 2014

@jefferyto - Hey thanks for the help, i actually got it working. Just ran gedit from the terminal so I could catch the errors, then it was pretty straightforward. My fork has the working fix in it, just couldn't figure out how to merge it back in, as I'm currently travelling and my internet connectivity isn't great.

Here's the commit:
suprafly/gedit-django-project@9123914

@jefferyto
Copy link
Author

@suprafly Glad you got it working 😄 You might find these useful: Using Pull Requests, Creating a pull request

@suprafly
Copy link

suprafly commented Feb 3, 2014

@jefferyto Thanks. I've used git heavily at work, this is my first time using it in a social way.

@raelgc
Copy link

raelgc commented Mar 29, 2014

How about merge?

@Kasual
Copy link

Kasual commented Jan 7, 2017

would love to see this merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants