-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gedit 3.8 compatibility #9
base: master
Are you sure you want to change the base?
Conversation
keep the old .plugin for gedit 3.0-3.6
…r warnings, so close it when idle
…d is not modified; reference the tab state constant instead of using its value directly
…rows an error so we fall back to GObject.idle_add()
Thanks for getting this ported. Wondering is you might be able to help me get the gedit-django-project plugin up to gedit 3.8? I've tried, but I haven't used python3 enough to see what I'm missing. |
Great fix - your port worked wonderfully on gedit 3.8.3, Ubuntu 13.10 |
@suprafly I'm a little low on free time lately, but I'll try to take a look at that plugin soon. If you post your work-in-progress (as a branch in your fork) and describe the error(s) you're seeing (as an issue, again in your fork), I might be able to help. @mrkeyboard Thanks! |
@jefferyto - Hey thanks for the help, i actually got it working. Just ran gedit from the terminal so I could catch the errors, then it was pretty straightforward. My fork has the working fix in it, just couldn't figure out how to merge it back in, as I'm currently travelling and my internet connectivity isn't great. Here's the commit: |
@suprafly Glad you got it working 😄 You might find these useful: Using Pull Requests, Creating a pull request |
@jefferyto Thanks. I've used git heavily at work, this is my first time using it in a social way. |
How about merge? |
would love to see this merged |
This updates the code to be compatible with gedit 3.8:
Would be great if this is merged soon as I have some other ideas I'd like to implement after this :-)