Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @mermaidchart/sdk #6

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add @mermaidchart/sdk #6

wants to merge 5 commits into from

Conversation

sidharthv96
Copy link
Member

No description provided.

Copy link
Contributor

@pbrolin47 pbrolin47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After conflicts resolved, its ok to merge

Copy link

@aloisklink aloisklink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get OAuth working on this PR currently, or even get the @mermaidchart/sdk working.

The following PRs in @mermaidchart/sdk seem to at least fix logging in for me, and everything else seems to work:

src/mermaidChartAuthenticationProvider.ts Outdated Show resolved Hide resolved
sidharthv96 and others added 2 commits August 23, 2024 18:49
* main:
  MC-848 Removing project id from the edit URL, skipping the check for projectID
  update urls for mermaid api
  Updated desctiption to remove the ending "Sim" visible in the description in the marketplace
@sidharthv96 sidharthv96 requested a review from aloisklink August 23, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants