Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project history : Add functionnalities for the version viewerin the QGIS plugin #222

Merged
merged 18 commits into from
Dec 3, 2024

Conversation

ValentinBuira
Copy link
Contributor

@ValentinBuira ValentinBuira commented Nov 28, 2024

This PR is required to support the history viewer in the QGIS as part of MerginMaps/qgis-plugin/pull/630

This PR contains:

  • update and add functions to fetch history information (pagination, range count)
  • Add a function to know the workspace usage right

@coveralls
Copy link

coveralls commented Nov 28, 2024

Pull Request Test Coverage Report for Build 12141406772

Details

  • 28 of 31 (90.32%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 79.092%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mergin/client_pull.py 1 2 50.0%
mergin/client.py 21 23 91.3%
Totals Coverage Status
Change from base Build 12068081183: 0.03%
Covered Lines: 3276
Relevant Lines: 4142

💛 - Coveralls

mergin/client.py Outdated Show resolved Hide resolved
mergin/client.py Outdated Show resolved Hide resolved
mergin/client.py Outdated Show resolved Hide resolved
mergin/client.py Outdated Show resolved Hide resolved
Copy link
Contributor

@MarcelGeo MarcelGeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some things as renaming method project_versions is not safe for me :)

mergin/client.py Outdated Show resolved Hide resolved
mergin/client.py Outdated Show resolved Hide resolved
mergin/client.py Outdated Show resolved Hide resolved
mergin/client.py Outdated Show resolved Hide resolved
@MarcelGeo MarcelGeo merged commit 70c48a9 into master Dec 3, 2024
4 checks passed
@MarcelGeo MarcelGeo deleted the project-history branch December 3, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants