Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for editable states and alias expressions for fields #3645

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Support for editable states and alias expressions for fields #3645

wants to merge 14 commits into from

Conversation

VitorVieiraZ
Copy link
Contributor

@VitorVieiraZ VitorVieiraZ commented Oct 16, 2024 •
edited
Loading

Screen.Recording.2024-10-17.at.08.28.44.mov

Resolves #2607, Resolves #3494

@VitorVieiraZ VitorVieiraZ changed the title WIP - Support for editable states and alias expressions for fields Support for editable states and alias expressions for fields Oct 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12236224310

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 162 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.06%) to 60.464%
Files with Coverage Reduction New Missed Lines %
input/core/merginapi.cpp 3 78.95%
input/app/attributes/attributedata.cpp 12 91.24%
input/app/attributes/attributecontroller.cpp 147 76.67%
Totals Coverage Status
Change from base Build 11601124075: 0.06%
Covered Lines: 7919
Relevant Lines: 13097
💛 - Coveralls

tomasMizera
tomasMizera approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :) I have just a bunch of small comments, but generally it looks good 👍🏻 @uclaros can I ask you to have a look here please?

app/attributes/attributecontroller.cpp Show resolved Hide resolved
app/attributes/attributedata.h Outdated Show resolved Hide resolved
app/attributes/attributedata.h Show resolved Hide resolved
app/attributes/attributecontroller.cpp Outdated Show resolved Hide resolved
app/attributes/attributecontroller.cpp Outdated Show resolved Hide resolved
app/attributes/attributedata.cpp Outdated Show resolved Hide resolved
@tomasMizera tomasMizera requested a review from uclaros November 19, 2024 15:56
uclaros
uclaros approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@uclaros uclaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I'd love some docstrings for the new items in FormItem.
Maybe add some comments to the new private members, as I see that's the only thing that's documented already :)

@alexd0793 alexd0793 added the test-success Label to use for PR testing label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uclaros uclaros uclaros approved these changes

@ValentinBuira ValentinBuira Awaiting requested review from ValentinBuira

@tomasMizera tomasMizera Awaiting requested review from tomasMizera

Assignees
No one assigned
Labels
test-success Label to use for PR testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alias as expression is not evaluated in the form Support for editable state of a field
5 participants
@VitorVieiraZ @uclaros @tomasMizera @inputapp-bot @alexd0793