Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatibility #13

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

jseabold
Copy link

Tests pass. Might need some more work. Haven't tried it much yet.

@chriskilding
Copy link
Contributor

Hi @jseabold we have just added Travis CI to auto build our project. If you pull in our latest changes from master, then edit the .travis.yml file section that sets the Python version to go from this:

python:

  • "2.7"

to simultaneously testing a Python 2 + 3 version of your choice, like this:

python:

  • "2.7"
  • "3.4"

Then Travis will non-destructively apply the changes in your pull request on top of the current master, and we can see if the build and tests still pass with your changes included.

@jseabold
Copy link
Author

Rebased. Let's see.

@chriskilding
Copy link
Contributor

It looks like multiple Python 2/3 compatibility libraries are in use. 'future' is used in some places and that dependency is present. But 'six' is used in others, and that's not yet declared in the install_requires array in setup.py, hence missing dependency error.

@jseabold
Copy link
Author

Failures look related? I have too new a numpy to test locally it looks like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants