Skip to content

Commit

Permalink
Merge pull request #1065
Browse files Browse the repository at this point in the history
* [chore] bump

* add viewerimage to post content

* remove image dimensions store

* remove old module for retrieving cache path

* add image viewer footer

* refactor hook organization

* cleanup

* remove unneeded haptics library

* better login validation

* changelog

* Add lemmy status

* changelog

* option to show full title in compact view

* fix issue where false positives of lemmy posts would not open

* fix a few issues with the keyboard accessory

* a few refactors

* add `getItemType` to feed flashlist

* add `getItemType` to feed flashlist
  • Loading branch information
gkasdorf authored Nov 6, 2023
1 parent 1aa78f2 commit 6ffdcda
Show file tree
Hide file tree
Showing 166 changed files with 270 additions and 3,908 deletions.
14 changes: 11 additions & 3 deletions App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import { LogBox } from 'react-native';
import { StatusBar } from 'expo-status-bar';
import { ErrorBoundary } from 'react-error-boundary';
import { writeToLog } from '@src/helpers';
import { useThemeSettings } from '@hooks/useThemeSettings';
import AppToast from '@components/Common/Toast/AppToast';

import { Drawer as RNDrawer } from 'react-native-drawer-layout';
Expand All @@ -37,12 +36,17 @@ import {
NavigationContainer,
useNavigationContainerRef,
} from '@react-navigation/native';
import { useBackgroundChecks } from '@hooks/useBackgroundChecks';
import { resetState } from '@src/state/resetState';
import ErrorScreen from '@components/Error/ErrorScreen';
import LoadingOverlay from '@components/Common/Loading/LoadingOverlay';
import { useNotificationsObserver } from '@hooks/useNotificationsObserver';
import { ImageViewerProvider } from 'expo-image-viewer';
import ImageViewerFooter from '@components/Common/ImageViewer/ImageViewerFooter';
import {
useBackgroundChecks,
useManageRootBackgroundColor,
useNotificationsObserver,
useThemeSettings,
} from '@src/hooks';

if (__DEV__) {
require('./ReactotronConfig');
Expand Down Expand Up @@ -158,6 +162,9 @@ function PartTwo(): React.JSX.Element {
// Handle notification redirects
useNotificationsObserver(navRef);

// Manage the background color
useManageRootBackgroundColor();

/* This is a little trick to completely reset our stack whenever we change accounts.
We don't want to have any remnant of leftover screens because the IDs for posts, profiles,
will be incorrect. We also will reset most of the stores here so we have a fresh, clean slate.
Expand Down Expand Up @@ -207,6 +214,7 @@ function PartTwo(): React.JSX.Element {
swipeToDismiss: true,
preloadImages: false,
heightModifier: ignoreScreenHeight ? 0.9 : 0.6,
FooterComponent: () => <ImageViewerFooter />,
}}
>
<AppToast />
Expand Down
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,29 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
_
## [Unreleased]

### Added

- Added link to Lemmy-Status.org to check if there is an issue with your instance.
- Option to show full title in compact view

### Changes

- Migrate image viewer into an external library. Took the time to properly handle scaling up and downsizes, animations,
etc.
- Performance improvements for feeds

### Fixed

- Issues that allowed users to sign in with incorrect values for instance or username have been fixed.
- This should fix issues with images that don't properly load crashing the app.
- Images that are loaded in comments show an activity indicator
- Activity indicator for images in the feeds is animated properly
- Better login validation
- Fix issue where the wrong background color was displayed while opening the drawer or rotating the device
- False positive Lemmy links should now open (i.e. https://newsrepublic.com/post/1234 isn't a Lemmy post)
- Old change, but it seems that NSFW GIF/WebPs are now blurred properly
- Bold and image accessories will now position the cursor inside the stars if no text is selected. The current behavior
of placing the cursor at the end of the stars will happen if any text was selected.

## [Version 1.1.1 (79)] - 2023-11-05T02:21:26Z

Expand Down
4 changes: 2 additions & 2 deletions ios/Memmy.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 79;
CURRENT_PROJECT_VERSION = 80;
DEVELOPMENT_TEAM = "";
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = M2T765RRB4;
ENABLE_BITCODE = NO;
Expand Down Expand Up @@ -406,7 +406,7 @@
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
CODE_SIGN_STYLE = Manual;
CURRENT_PROJECT_VERSION = 79;
CURRENT_PROJECT_VERSION = 80;
DEVELOPMENT_TEAM = "";
"DEVELOPMENT_TEAM[sdk=iphoneos*]" = M2T765RRB4;
INFOPLIST_FILE = Memmy/Info.plist;
Expand Down
2 changes: 1 addition & 1 deletion ios/Memmy/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>79</string>
<string>80</string>
<key>LSApplicationCategoryType</key>
<string>public.app-category.social-networking</string>
<key>LSRequiresIPhoneOS</key>
Expand Down
13 changes: 0 additions & 13 deletions ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,6 @@ PODS:
- SDWebImageAVIFCoder (~> 0.10.1)
- SDWebImageSVGCoder (~> 1.7.0)
- SDWebImageWebPCoder (~> 0.13.0)
- ExpoImageCachePath (1.0.0):
- ExpoModulesCore
- SDWebImage (~> 5.17.0)
- ExpoImagePicker (14.5.0):
- ExpoModulesCore
- ExpoKeepAwake (12.3.0):
Expand Down Expand Up @@ -653,8 +650,6 @@ PODS:
- RNGestureHandler (2.13.4):
- RCT-Folly (= 2021.07.22.00)
- React-Core
- RNReactNativeHapticFeedback (2.2.0):
- React-Core
- RNReanimated (3.3.0):
- DoubleConversion
- FBLazyVector
Expand Down Expand Up @@ -729,7 +724,6 @@ DEPENDENCIES:
- ExpoDevice (from `../node_modules/expo-device/ios`)
- ExpoHaptics (from `../node_modules/expo-haptics/ios`)
- ExpoImage (from `../node_modules/expo-image/ios`)
- ExpoImageCachePath (from `../modules/expo-image-cache-path/ios`)
- ExpoImagePicker (from `../node_modules/expo-image-picker/ios`)
- ExpoKeepAwake (from `../node_modules/expo-keep-awake/ios`)
- ExpoLinearGradient (from `../node_modules/expo-linear-gradient/ios`)
Expand Down Expand Up @@ -813,7 +807,6 @@ DEPENDENCIES:
- "RNFlashList (from `../node_modules/@shopify/flash-list`)"
- RNFS (from `../node_modules/react-native-fs`)
- RNGestureHandler (from `../node_modules/react-native-gesture-handler`)
- RNReactNativeHapticFeedback (from `../node_modules/react-native-haptic-feedback`)
- RNReanimated (from `../node_modules/react-native-reanimated`)
- RNScreens (from `../node_modules/react-native-screens`)
- RNShare (from `../node_modules/react-native-share`)
Expand Down Expand Up @@ -888,8 +881,6 @@ EXTERNAL SOURCES:
:path: "../node_modules/expo-haptics/ios"
ExpoImage:
:path: "../node_modules/expo-image/ios"
ExpoImageCachePath:
:path: "../modules/expo-image-cache-path/ios"
ExpoImagePicker:
:path: "../node_modules/expo-image-picker/ios"
ExpoKeepAwake:
Expand Down Expand Up @@ -1009,8 +1000,6 @@ EXTERNAL SOURCES:
:path: "../node_modules/react-native-fs"
RNGestureHandler:
:path: "../node_modules/react-native-gesture-handler"
RNReactNativeHapticFeedback:
:path: "../node_modules/react-native-haptic-feedback"
RNReanimated:
:path: "../node_modules/react-native-reanimated"
RNScreens:
Expand Down Expand Up @@ -1045,7 +1034,6 @@ SPEC CHECKSUMS:
ExpoDevice: 4b9825263a3f996fd5a89ec26426e22e6cbc32d6
ExpoHaptics: 604aca02e942d1d43c139cae7cf397b26f85476f
ExpoImage: a02f1b0c514f3521c8b442a93687f927ef2c0d8d
ExpoImageCachePath: 5bb1072da668ab3938c7d11b717d76920a41a1b7
ExpoImagePicker: 9e5c745cb3e56ee00e1cfe5d6af59caab66ecf1a
ExpoKeepAwake: be4cbd52d9b177cde0fd66daa1913afa3161fc1d
ExpoLinearGradient: 5966dd5d49872cc9c104fedc8bbc298b6049b2e8
Expand Down Expand Up @@ -1120,7 +1108,6 @@ SPEC CHECKSUMS:
RNFlashList: 1983f915ae34e9253e413f31387959590d102f5e
RNFS: 4ac0f0ea233904cb798630b3c077808c06931688
RNGestureHandler: 6e46dde1f87e5f018a54fe5d40cd0e0b942b49ee
RNReactNativeHapticFeedback: ec56a5f81c3941206fd85625fa669ffc7b4545f9
RNReanimated: 9f7068e43b9358a46a688d94a5a3adb258139457
RNScreens: 3c2d122f5e08c192e254c510b212306da97d2581
RNShare: 32e97adc8d8c97d4a26bcdd3c45516882184f8b6
Expand Down
89 changes: 0 additions & 89 deletions modules/expo-image-cache-path/android/build.gradle

This file was deleted.

This file was deleted.

Binary file not shown.

This file was deleted.

Binary file not shown.

This file was deleted.

Binary file not shown.

This file was deleted.

Binary file not shown.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Binary file not shown.
Binary file not shown.
Loading

0 comments on commit 6ffdcda

Please sign in to comment.