issue: 4197123: Add Pytest to the workflow of the LogAnalyzer + issue: 4197133: Add Pytest #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miryam-Schwartz
changed the title
boazhaim
reviewed
Dec 8, 2024
boazhaim
reviewed
Dec 8, 2024
boazhaim
reviewed
Dec 8, 2024
plugins/ufm_log_analyzer_plugin/unit_tests/test_ibdiagnet_log_analyzer.py
Outdated
Show resolved
Hide resolved
plugins/ufm_log_analyzer_plugin/unit_tests/test_ibdiagnet_log_analyzer.py
Outdated
Show resolved
Hide resolved
plugins/ufm_log_analyzer_plugin/unit_tests/test_ibdiagnet_log_analyzer.py
Outdated
Show resolved
Hide resolved
plugins/ufm_log_analyzer_plugin/unit_tests/test_ibdiagnet_log_analyzer.py
Outdated
Show resolved
Hide resolved
boazhaim
reviewed
Dec 8, 2024
plugins/ufm_log_analyzer_plugin/unit_tests/test_ibdiagnet_log_analyzer.py
Outdated
Show resolved
Hide resolved
plugins/ufm_log_analyzer_plugin/unit_tests/test_ibdiagnet_log_analyzer.py
Outdated
Show resolved
Hide resolved
plugins/ufm_log_analyzer_plugin/unit_tests/test_ibdiagnet_log_analyzer.py
Outdated
Show resolved
Hide resolved
plugins/ufm_log_analyzer_plugin/unit_tests/test_ibdiagnet_log_analyzer.py
Outdated
Show resolved
Hide resolved
drorlevy
reviewed
Dec 10, 2024
|
@drorlevy , these are only unit tests and do not test the entire flow. |
drorlevy
approved these changes
Dec 11, 2024
boazhaim
reviewed
Dec 11, 2024
Comment on lines
82
to
85
| 1. Make sure you have `pytest` installed. If not, you can install it using `pip`: | ||
|
|
||
| ```bash | ||
| pip install pytest |
There was a problem hiding this comment.
It should be clear that you use the venv created for the tool, right? otherwise tests might fail due to missing dependencies
| return TestIBDIAGNETLogAnalyzer(fabric_size_data) | ||
|
|
||
| def test_get_fabric_size(analyzer, fabric_size_data): | ||
| # Call the method and check the result |
There was a problem hiding this comment.
I don't see the benefit in having this comment
plugins/ufm_log_analyzer_plugin/unit_tests/test_ibdiagnet_log_analyzer.py
Outdated
Show resolved
Hide resolved
boazhaim
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add pytest to log analyzer workflow and add some basics tests for this plugin.
Why ?
In order to test the plugin.
How ?
Pytest session was added to ufm_log_analyzer_ci_workflow.yml
unit_tesst directory was added with two simple unit tests.
Testing ?
Ensure tests passed.
Special triggers
Use the following phrases as comments to trigger different runs
bot:retestrerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgraderun additional update tests