issue: 4197110: Add the collectx versions to the to the PDF #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boazhaim
reviewed
Dec 5, 2024
...ns/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/ibdiagnet2_port_counters_analyzer.py
Outdated
Show resolved
Hide resolved
boazhaim
approved these changes
Dec 5, 2024
drorlevy
changed the title
drorlevy
approved these changes
Dec 5, 2024
boazhaim
reviewed
Dec 5, 2024
Comment on lines
+63
to
+64
| for txt in self._txt_list: | ||
| print(txt, file=output) |
There was a problem hiding this comment.
If you touched it :) (Which is great!)
Why do we need this logic? Cant we add these texts and combine them with the text we send in add_list_of_dicts_as_text ?
(will also mean a small refactor, but it makes sense)
Not a must right now...
plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/console_log_analyzer.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add the collectx versions to the to the PDF.
Why ?
Display of extracted data.
How ?
_save_collectx_versions method was added to the class set _funcs_for_analysis. This method extracts the versions and save them in dataframes_for_pdf list.
Testing ?
Tested manually to ensure the output looks the same as before the change.
Special triggers
Use the following phrases as comments to trigger different runs
bot:retestrerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgraderun additional update tests