-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #4151551: TFS plugin refactor streamer.py file #278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, Miryam!
please see my initial commits, I still need to review the functionality.
and also, please make sure to set the correct git configurations, need to append the current commits to show your name instead of root
plugins/fluentd_telemetry_plugin/src/streaming_config_parser.py
Outdated
Show resolved
Hide resolved
plugins/fluentd_telemetry_plugin/src/telemetry_attributes_manager.py
Outdated
Show resolved
Hide resolved
6e6f954
to
b17c119
Compare
@Miryam-Schwartz , general comment, please also review the current README file and make sure it doesn't contain any information about the removed functionalities , such as supporting the promethues format and inline args |
What
1. Create a seperate file for each class located in the streamer.py file
2. Remove the data fetching in the Prometheus format
3. Remove the inline args usage from the flow
4. Break the UFMTelemetryStreaming class into more granular classes
Why ?
https://redmine.mellanox.com/issues/4151551.
Remove unused functionality and break large file into smaller ones.
How ?
_
Break the UFMTelemetryStreaming class into three classes:
_
Testing ?
Regression tests for TFS
Special triggers
Use the following phrases as comments to trigger different runs
bot:retest
rerun Jenkins CI (to rerun GitHub CI, use "Checks" tab on PR page and rerun all jobs)bot:upgrade
run additional update tests