-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce NDT plugin size by removing MOFED. #178
Open
BennyItkin
wants to merge
5
commits into
main
Choose a base branch
from
reduce_plugin_size_1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BennyItkin
force-pushed
the
reduce_plugin_size_1
branch
2 times, most recently
from
February 19, 2024 09:48
98000c8
to
a09d6eb
Compare
atolikin94
approved these changes
Feb 19, 2024
bot:retest |
4 similar comments
bot:retest |
bot:retest |
bot:retest |
bot:retest |
BennyItkin
force-pushed
the
reduce_plugin_size_1
branch
from
February 25, 2024 20:28
5e8b2b1
to
9c980b8
Compare
BennyItkin
force-pushed
the
reduce_plugin_size_1
branch
from
March 14, 2024 17:55
9c980b8
to
9fc7038
Compare
lennybe
approved these changes
Apr 10, 2024
bot:retest |
BennyItkin
force-pushed
the
reduce_plugin_size_1
branch
from
May 7, 2024 13:03
9fc7038
to
2fed0ae
Compare
bot:retest |
1 similar comment
bot:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove full MOFED installation from the NDT plugin to reduce the container size, the only tool that is needed is ibdiagnet which will be the only installed tool from MOFED.