encapsulation

Mellanox · Dec 1, 2024 · caf3629 · caf3629
1 parent 3abbad1
commit caf3629
Show file tree

Hide file tree

Showing 6 changed files with 37 additions and 22 deletions.
diff --git a/plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzer.py b/plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzer.py
@@ -369,8 +369,10 @@ def create_analyzer(
         end = time.perf_counter()
         log.LOGGER.debug(f"Took {end-start:.3f} to load the parsed data")
 
-        all_images_outputs_and_title, dataframes_for_pdf, lists_to_add = \
+        all_images_outputs_and_title, dataframes_for_pdf, lists_to_add = (
             ufm_top_analyzer.full_analysis_all_analyzers()
+            )
+
         png_images = []
         images_and_title_to_present = []
         for image_title in all_images_outputs_and_title:

diff --git a/plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/base_analyzer.py b/plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/base_analyzer.py
@@ -196,11 +196,14 @@ def __init__(
     def _remove_empty_lines_from_csv(input_file):
         temp_file = input_file + ".temp"
 
-        with open(
-            input_file, "r", newline="", encoding=DataConstants.UTF8ENCODING
-        ) as infile, open(
-            temp_file, "w", newline="", encoding=DataConstants.UTF8ENCODING
-        ) as outfile:
+        with (
+            open(
+                input_file, "r", newline="", encoding=DataConstants.UTF8ENCODING
+            ) as infile,
+            open(
+                temp_file, "w", newline="", encoding=DataConstants.UTF8ENCODING
+            ) as outfile,
+        ):
             reader = csv.reader(infile)
             writer = csv.writer(outfile)
 

diff --git a/plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/console_log_analyzer.py b/plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/console_log_analyzer.py
@@ -43,11 +43,14 @@ def _extract_ufm_version(logs_csvs):
             temp_file = csv_file + ".temp"
 
             # Open the input CSV file for reading
-            with open(
-                csv_file, mode="r", newline="", encoding=DataConstants.UTF8ENCODING
-            ) as infile, open(
-                temp_file, mode="w", newline="", encoding=DataConstants.UTF8ENCODING
-            ) as outfile:
+            with (
+                open(
+                    csv_file, mode="r", newline="", encoding=DataConstants.UTF8ENCODING
+                ) as infile,
+                open(
+                    temp_file, mode="w", newline="", encoding=DataConstants.UTF8ENCODING
+                ) as outfile,
+            ):
                 reader = csv.DictReader(infile)
                 fieldnames = reader.fieldnames  # Get the header from the CSV
                 writer = csv.DictWriter(outfile, fieldnames=fieldnames)

diff --git a/...ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/ibdiagnet2_port_counters_analyzer.py b/...ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/ibdiagnet2_port_counters_analyzer.py
@@ -220,11 +220,11 @@ def full_analysis(self):
         )
 
         lists_to_add.append(
-                (
-                    [self.get_number_of_core_dumps()],
-                    f"{self.telemetry_type} "
-                    "number of core dumps found in the logs",
-                    ["Amount"],
-                )
+            (
+                [self.get_number_of_core_dumps()],
+                f"{self.telemetry_type} "
+                "number of core dumps found in the logs",
+                ["Amount"],
             )
+        )
         return images, dataframes_for_pdf, lists_to_add
diff --git a/plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/link_flapping_analyzer.py b/plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/link_flapping_analyzer.py
@@ -144,5 +144,10 @@ def plot_link_flapping_last_week(self):
     def full_analysis(self):
         link_flapping_last_week = self.get_link_flapping_last_week()
         images, _, _ = super().full_analysis()
-        df = [("Link Flapping last week", link_flapping_last_week,)]
+        df = [
+            (
+                "Link Flapping last week",
+                link_flapping_last_week,
+            )
+        ]
         return images, df, []
diff --git a/plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/ufm_top_analyzer.py b/plugins/ufm_log_analyzer_plugin/src/loganalyze/log_analyzers/ufm_top_analyzer.py
@@ -13,8 +13,9 @@
 # pylint: disable=missing-module-docstring
 
 
-from plugins.ufm_log_analyzer_plugin.src.loganalyze.log_analyzers.ibdiagnet_log_analyzer\
-    import IBDIAGNETLogAnalyzer
+from plugins.ufm_log_analyzer_plugin.src.loganalyze.log_analyzers.ibdiagnet_log_analyzer import (
+    IBDIAGNETLogAnalyzer,
+)
 
 
 class UFMTopAnalyzer:
@@ -37,8 +38,9 @@ def full_analysis_all_analyzers(self):
             dataframes.extend(tmp_dataframes)
             lists_to_add.extend(tmp_lists)
 
-        has_ibdiagnet_analyzer = any(isinstance(instance, IBDIAGNETLogAnalyzer) \
-                                     for instance in self._analyzers)
+        has_ibdiagnet_analyzer = any(
+            isinstance(instance, IBDIAGNETLogAnalyzer) for instance in self._analyzers
+        )
         if not has_ibdiagnet_analyzer:
             dataframes.append(("Fabric info", ("No Fabric Info found")))