ci: Push artifacts versions to Network Operator repo #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
Pull Request Test Coverage Report for Build 12479808379Details
💛 - Coveralls |
rollandf
reviewed
Dec 3, 2024
.github/workflows/fork-ci.yaml
Outdated
| if [ -z "${IS_BETA}" ]; then | ||
| echo "BRANCH_NAME=master" >> $GITHUB_ENV | ||
| else | ||
| echo "BRANCH_NAME="$DOCKER_TAG" >> $GITHUB_ENV |
There was a problem hiding this comment.
BRANCH_NAME here will be in format 'v25.01.x'? It looks it take the tag as is
There was a problem hiding this comment.
In SR-IOV we use the format like "network-operator-24.1.0-beta.3".
There was a problem hiding this comment.
The PR is going to be opened on Network-Operator repo.
The branch there should be master for beta, and eg. v24.10.x for rc and GA
.github/workflows/fork-ci.yaml
Outdated
| git config user.email [email protected] | ||
|
|
||
| git checkout -b feature/update-sriov-tags-to-$DOCKER_TAG | ||
| sed -Ei "s/(version: )network-operator-.+/\\1$DOCKER_TAG/g" hack/release.yaml |
There was a problem hiding this comment.
There are more changes here needed according to existing "draft-image-builder"
maze88
reviewed
Dec 9, 2024
maze88
reviewed
Dec 9, 2024
maze88
reviewed
Dec 9, 2024
maze88
reviewed
Dec 24, 2024
Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
rollandf
reviewed
Dec 25, 2024
|
|
||
| git checkout -b feature/update-sriov-tags-to-$DOCKER_TAG | ||
| yq -i e '.SriovNetworkOperator.repository |= "${{ env.DOCKER_REGISTRY }}"' hack/release.yaml | ||
| yq -i e '.SriovNetworkOperator.version |= "${{ env.DOCKER_TAG }}"' hack/release.yaml |
There was a problem hiding this comment.
Some steps are different from current draft-image-builder.jenkinsfile
- Need to sync the helm chart
- When is the Network Operator image built and release.yaml updated with it?
- When is the Chart.yaml updated?
- All GA handling (different repositories)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.