Make send check non-blocking to allow other workers to be progressed #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brminich
reviewed
Nov 2, 2023
brminich
approved these changes
Nov 3, 2023
tvegas1
force-pushed
the
dev/send_check_nonblock
branch
from
cd21977 to
554b171
Compare
bureddy
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make
ucx_send_check()connection establishment non-blocking. This prepares later patch changing worker allocation scheme.Why
When blocking on send check, this could cause dead-locks if on more than one node, other endpoints on other workers need to be progressed.
How
Make send check non-blocking. Next cleanup step can be moving send/recv check functions to connect/accept, delayed as it is causing other issues (#128)