-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple scheduler #4
Conversation
Pull Request Test Coverage Report for Build 10092907433Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! The PR looks good. I added few small comments
return 1 | ||
}) | ||
|
||
// compact entries pointing to the same Node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understood the logic correctly, in the compacted list we want to keep only one entry for a specific node (the entry which has more priority). Right? Can you add a bit more details to the comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes will add more context.
this logic will change as we progress with implementation to be more elaborate. however, i believe current logic can carry use quite well.
Implement basic controller that reconciles periodically and does nothing ATM Signed-off-by: adrianc <[email protected]>
- Update golangci yml file to not fail on autogenerated files - Regenerate api to update license with NVIDIA - remove kube-rbac-proxy from manager in kustomize configs Signed-off-by: adrianc <[email protected]>
- add function to print canonical form of NodeMaintenance this will be later used in controller implementation. Signed-off-by: adrianc <[email protected]>
- k8sutils contains utility functions related to k8s. ATM maintly to manipulate objects - utils contains general utility functions - testutils contains common function for tests which will be used in subsequent commits Signed-off-by: adrianc <[email protected]>
Signed-off-by: adrianc <[email protected]>
- Implement basic logic to transition NodeMaintenance obj to pending state - Add basic controler test for the logic This is the minimal set of changes to be able to kick in the scheduler controller implemented in subsequent commit Signed-off-by: adrianc <[email protected]>
- Scheduler interface definition - default scheduler implementation - tests Signed-off-by: adrianc <[email protected]>
nodemaintenance scheduller controller reconciles NodeMaintenance objects in Pending state, transitioning their state to Scheduled according to reommendation returned by the Scheduler. Signed-off-by: adrianc <[email protected]>
Signed-off-by: adrianc <[email protected]>
Signed-off-by: adrianc <[email protected]>
ea2ab1a
to
da6ce8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, for addressing my comments. LGTM
This PR (eventually) implements the scheduler controller with a simple scheduling logic that will be modified
as we progress with implementation.
please refer to individual commits for more information.
recommendation is to review commit by commit.
current state after this PR: one can deploy the operator, create NodeMaintenance objects which will transition from Uninitialized state to Pending and finally to Scheduled.