Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split api to its own module & update packages #23

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

adrianchiris
Copy link
Collaborator

@adrianchiris adrianchiris commented Sep 3, 2024

this will allow users to import only API package
without the rest of the project dependencies.

spliting to separate go module has bumped k8s and controller runtime version to latest (1.31 and 0.19.0 respectively).
decided to roll it it for this PR so it contains the version bump as well.

some minor changed needed for controller UT and reconciler initialization due to changes.

this will allow users to import only API package
without the rest of the project dependencies.

Signed-off-by: adrianc <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10684802959

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.7%) to 68.301%

Totals Coverage Status
Change from base Build 10678217242: 2.7%
Covered Lines: 989
Relevant Lines: 1448

💛 - Coveralls

Copy link
Collaborator

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykulazhenkov ykulazhenkov merged commit 39f04ef into Mellanox:main Sep 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants