Add helm chart #22
Merged
Add helm chart #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adrianchiris
commented
Sep 1, 2024
•
adrianchiris
commented
- add helm chart
- add automation and release workflow for helm chart
adrianchiris
force-pushed
the
add-helm-chart
branch
from
3bd4809 to
990649a
Compare
Pull Request Test Coverage Report for Build 10665553447Details
💛 - Coveralls |
adrianchiris
force-pushed
the
add-helm-chart
branch
2 times, most recently
from
3b8fd47 to
e6a6039
Compare
ykulazhenkov
reviewed
Sep 2, 2024
| GITHUB_TAG: ${{ github.ref_name }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GITHUB_REPO_OWNER: ${{ github.repository_owner }} | ||
| run: make chart-push-release |
There was a problem hiding this comment.
nit: no new line at the end
|
|
||
| GOLANGCI_LINT = $(LOCALBIN)/golangci-lint | ||
| GOLANGCI_LINT_VERSION ?= v1.59.1 | ||
| golangci-lint: |
There was a problem hiding this comment.
missing .PHONY entry for golangci-lint
| .PHONY: yq | ||
| yq: $(YQ) ## Download yq locally if necessary. | ||
| $(YQ): | $(LOCALBIN) | ||
| @curl -fsSL -o $(YQ) https://github.com/mikefarah/yq/releases/download/$(YQ_VERSION)/yq_linux_amd64 && chmod +x $(YQ) |
There was a problem hiding this comment.
Here we always download x86 binary. Do we want to download the binary that matches the arch of the build host?
There was a problem hiding this comment.
i dont think its needed. its intended to be run in GH runner.
| control-plane: {{ .Release.Name }}-controller-manager | ||
| {{- include "maintenance-operator.selectorLabels" . | nindent 4 }} | ||
| ports: | ||
| {{- .Values.metricsService.ports | toYaml | nindent 2 }} |
There was a problem hiding this comment.
No new line at the end + mixing of spaces and tabs?
| app.kubernetes.io/part-of: maintenance-operator | ||
| {{- include "maintenance-operator.labels" . | nindent 4 }} | ||
| spec: | ||
| logLevel: info |
There was a problem hiding this comment.
nit: no new line at the end
| control-plane: {{ .Release.Name }}-controller-manager | ||
| {{- include "maintenance-operator.selectorLabels" . | nindent 4 }} | ||
| ports: | ||
| {{- .Values.webhookService.ports | toYaml | nindent 2 }} |
There was a problem hiding this comment.
I think we should automatically update CRDs in the helm chart's dir with make manifests. WDYT?
There was a problem hiding this comment.
makes sense.
also i will add some additional values for operator config CR in the templates.
adrianchiris
force-pushed
the
add-helm-chart
branch
from
e6a6039 to
3a347b4
Compare
Signed-off-by: adrianc <[email protected]>
push helm chart as oci image to ghcr on release (tag) Signed-off-by: adrianc <[email protected]>
adrianchiris
force-pushed
the
add-helm-chart
branch
from
3a347b4 to
68e169a
Compare
ykulazhenkov
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.