Add additional requestors #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10511201415Details
💛 - Coveralls |
adrianchiris
force-pushed
the
add-additional-requestors
branch
from
38f6e93 to
ec0c566
Compare
| defaultMaxNodeMaintenanceTime = 1600 * time.Second | ||
| waitPodCompletionRequeueTime = 10 * time.Second | ||
| drainReqeueTime = 10 * time.Second | ||
| defaultMaxNodeMaintenanceTime = 1600 * time.Second |
There was a problem hiding this comment.
nit: Time > Seconds?
It is ok for me keep the "time" postfix if you prefer so
There was a problem hiding this comment.
lets keeps as is :)
- remove un-needed protobuf markers - remove unsupported strategic merge related markes as they are not supported for CRDs [1] - add new field in spec: AdditionalRequestors to be used to allow multiple entities to share the same NodeMaintenance object. [1] kubernetes/kubectl#1280 Signed-off-by: adrianc <[email protected]>
nodemaintenance controller modifications to support additionalRequestors. - check that no additional requestors are present before proceeding with object removal flow when object is in ready state - update controller tests Signed-off-by: adrianc <[email protected]>
adrianchiris
force-pushed
the
add-additional-requestors
branch
from
ec0c566 to
0f5f558
Compare
|
Merging once CI is green, thx for the review ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only last two commits are relevant, the rest is PR #9