[FIX] Fixed benchmark using overlaps for the regular actor set transf…

…orm example (It's still faster 25% or so?)

[UPD] Changed transform bench actors to have a hierarchy of scene components and for the benchmark to tally up an average
[FIX] SetWorldTransformFastPath now accounts for multiple children correctly instead of overwriting the transform

Config/DefaultEngine.ini

@@ -1,5 +1,5 @@
 [/Script/EngineSettings.GameMapsSettings]
-EditorStartupMap=/Game/MassSample/Maps/MassSampleHall.MassSampleHall
+EditorStartupMap=/MassCommunitySample/MassSample/Maps/MassSampleHall.MassSampleHall
 LocalMapOptions=
 TransitionMap=None
 bUseSplitscreen=False

Plugins/MassCommunitySample/Source/MassCommunitySample/Experimental/Benchmark/MSSceneCompTransformToActorTranslators.cpp

@@ -12,7 +12,7 @@ UMSTransformToSceneCompTranslatorFastPath::UMSTransformToSceneCompTranslatorFast
 	ExecutionFlags = (int32)EProcessorExecutionFlags::All;
 	ExecutionOrder.ExecuteInGroup = UE::Mass::ProcessorGroupNames::UpdateWorldFromMass;
 	ExecutionOrder.ExecuteAfter.Add(UE::Mass::ProcessorGroupNames::Movement);
-	
+
 	RequiredTags.Add<FMSMassTransformToSceneCompFastPathTag>();
 
 	bRequiresGameThreadExecution = true;
@@ -27,13 +27,12 @@ void UMSTransformToSceneCompTranslatorFastPath::ConfigureQueries()
 }
 
 void UMSTransformToSceneCompTranslatorFastPath::Execute(FMassEntityManager& EntityManager,
-                                                                 FMassExecutionContext& Context)
+                                                        FMassExecutionContext& Context)
 {
 	EntityQuery.ForEachEntityChunk(EntityManager, Context, [this](FMassExecutionContext& Context)
 	{
-		const TConstArrayView<FMassSceneComponentWrapperFragment> ComponentList = Context.GetFragmentView<
-			FMassSceneComponentWrapperFragment>();
-		const TArrayView<FTransformFragment> LocationList = Context.GetMutableFragmentView<FTransformFragment>();
+		const auto ComponentList = Context.GetFragmentView<FMassSceneComponentWrapperFragment>();
+		const auto LocationList = Context.GetMutableFragmentView<FTransformFragment>();
 
 		const int32 NumEntities = Context.GetNumEntities();
 
@@ -66,8 +65,8 @@ void UMSSceneCompTransformToMassTranslator::Execute(FMassEntityManager& EntityMa
 {
 	EntityQuery.ForEachEntityChunk(EntityManager, Context, [this](FMassExecutionContext& Context)
 	{
-		const TConstArrayView<FMassSceneComponentWrapperFragment> ComponentList = Context.GetFragmentView<FMassSceneComponentWrapperFragment>();
-		const TArrayView<FTransformFragment> LocationList = Context.GetMutableFragmentView<FTransformFragment>();
+		const auto ComponentList = Context.GetFragmentView<FMassSceneComponentWrapperFragment>();
+		const auto LocationList = Context.GetMutableFragmentView<FTransformFragment>();
 
 		const int32 NumEntities = Context.GetNumEntities();
 		for (int32 i = 0; i < NumEntities; ++i)

Plugins/MassCommunitySample/Source/MassCommunitySample/Experimental/Benchmark/MSSceneCompTransformToActorTranslators.h

@@ -28,36 +28,44 @@ class MASSCOMMUNITYSAMPLE_API UMSTransformToSceneCompTranslatorFastPath : public
 
 
 	// Thanks to vblanco for this fast transform setting trick
-	// According to him the first two steps (to world and updatebounds) can be threaded but not the render dirty
-	FORCEINLINE static void SetWorldTransformFastPath(USceneComponent* InComp, FTransform InTransform)
+	// According to him the first two steps (comp to world and updatebounds) can be threaded but not the render dirty
+	FORCEINLINE static void SetWorldTransformFastPath(USceneComponent* InComp, const FTransform& InTransform)
 	{
-        
+		// directly set transform and update bounds 
 		InComp->SetComponentToWorld(InTransform);
 		InComp->UpdateBounds();
+
+		// Evil temp physics set with static cast
+		auto bodyinstance = static_cast<UPrimitiveComponent*>(InComp)->BodyInstance;
+		FChaosEngineInterface::SetGlobalPose_AssumesLocked(bodyinstance.ActorHandle, InTransform);
+
+		// dirty the render transform 
 		InComp->MarkRenderTransformDirty();
+
 		for (auto Component : InComp->GetAttachChildren())
 		{
 			// This * transforms from local space to world space!
-			InTransform = Component->GetRelativeTransform() * InTransform;
+			FTransform CompWorldTransform = Component->GetRelativeTransform() * InTransform;
 
 			//These are to support non-relative transforms (could probably omit as this is rare?)
-			if(InComp->IsUsingAbsoluteLocation())
+
+			if(UNLIKELY(InComp->IsUsingAbsoluteLocation()))
 			{
-				InTransform.CopyTranslation(InTransform);
+				CompWorldTransform.CopyTranslation(InTransform);
 			}
-
-			if(InComp->IsUsingAbsoluteRotation())
+			
+			if(UNLIKELY(InComp->IsUsingAbsoluteRotation()))
 			{
-				InTransform.CopyRotation(InTransform);
+				CompWorldTransform.CopyRotation(InTransform);
 			}
-
-			if(InComp->IsUsingAbsoluteScale())
+			
+			if(UNLIKELY(InComp->IsUsingAbsoluteScale()))
 			{
-				InTransform.CopyScale3D(InTransform);
+				CompWorldTransform.CopyScale3D(InTransform);
 			}
 
 			// Recursive!
-			SetWorldTransformFastPath(Component,InTransform);
+			SetWorldTransformFastPath(Component,CompWorldTransform);
 		}
 	};
 

Plugins/MassCommunitySample/Source/MassCommunitySample/MassCommunitySample.Build.cs

@@ -25,7 +25,9 @@ public MassCommunitySample(ReadOnlyTargetRules Target) : base(Target)
 				"Core", 
 				"CoreUObject", 
 				"Engine", 
-				"InputCore" 
+				"InputCore" ,
+				"Chaos"
+
 			}
 		);
 
@@ -59,11 +61,16 @@ public MassCommunitySample(ReadOnlyTargetRules Target) : base(Target)
 				"StateTreeModule",
 				"MassLOD",
 				"NavigationSystem",
-				//todo: maybe do thee editor only stuff on another module?
+				"Chaos",
+				"PhysicsCore",
+				"ChaosCore",
+				"ChaosSolverEngine"
 
+
 			}
 		);
-
+						//todo: maybe do thee editor only stuff on another module?
+
 		if (Target.bBuildEditor)
 		{
 			PrivateDependencyModuleNames.Add("CodeView");

Source/MassSampleProject.Target.cs

@@ -11,5 +11,7 @@ public MassSampleProjectTarget(TargetInfo Target) : base(Target)
 		DefaultBuildSettings = BuildSettingsVersion.V2;
 		ExtraModuleNames.AddRange(new string[] { "MassSampleProject" });
 
+		IncludeOrderVersion = EngineIncludeOrderVersion.Latest;
+
 	}
 }

Source/MassSampleProjectEditor.Target.cs

@@ -10,5 +10,8 @@ public MassSampleProjectEditorTarget(TargetInfo Target) : base(Target)
 		Type = TargetType.Editor;
 		DefaultBuildSettings = BuildSettingsVersion.V2;
 		ExtraModuleNames.Add("MassSampleProject");
+
+		IncludeOrderVersion = EngineIncludeOrderVersion.Latest;
+
 	}
 }