Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename shell extension Verb Id #997

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

cjee21
Copy link
Collaborator

@cjee21 cjee21 commented Dec 16, 2024

Workaround Windows issue causing shell extension to not appear in classic context menus on certain systems.
As seen in #994 (comment) and #994 (comment).

I have no idea what letter works in our case so let us just try "C" since it worked for NanaZip.

Thanks to M2Team/NanaZip#205.

@cjee21
Copy link
Collaborator Author

cjee21 commented Dec 16, 2024

@JeromeMartinez since we cannot reproduce this because we do not know what conditions trigger this issue, the only way is to build then ask those affected to test then if it still does not work, make changes to the Id and repeat again.

@JeromeMartinez
Copy link
Member

@cjee21
Copy link
Collaborator Author

cjee21 commented Dec 17, 2024

@JeromeMartinez Still works fine on my primary PC (Windows 11 24H2 26100.2605, AMD64, 10 apps with packaged context menu shell extension installed).

01 02
03 04

@sevastopolcat
Copy link

Yes, it works! The MediaInfo item is in the context menu of media files and folders in Explorer and Total Commander.
Windows 11 26100.2605

@JeromeMartinez
Copy link
Member

Yes, it works! The MediaInfo item is in the context menu of media files and folders in Explorer and Total Commander.

So it was not working with "M" as start of the string but "C" is working, that is crazy... But if it is the way, we do that...

@cjee21
Copy link
Collaborator Author

cjee21 commented Dec 17, 2024

So it was not working with "M" as start of the string but "C" is working, that is crazy... But if it is the way, we do that...

Crazy indeed and the fact that it only happens on certain systems.

At least it is not as bad as some Android bugs that cause files to disappear overnight due to special chars in folder names or download of same filename overwriting the previous file silently even after previous has been moved out of downloads folder.

Workaround Windows issue causing shell extension to not appear in classic context menus on certain systems.
@JeromeMartinez JeromeMartinez merged commit a7a4252 into MediaArea:master Dec 17, 2024
3 checks passed
@cjee21 cjee21 deleted the shellext-verb-id branch December 17, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants