Skip to content

Commit

Permalink
Windows GUI: Implement signing of uninstaller
Browse files Browse the repository at this point in the history
  • Loading branch information
cjee21 committed Nov 26, 2024
1 parent 731eb35 commit 366729f
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Source/Install/MediaInfo_GUI_Windows.nsi
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ SetCompressor /FINAL /SOLID lzma
!include "MUI2.nsh"
!define MUI_ABORTWARNING
!define MUI_ICON "..\..\Source\Resource\Image\MediaInfo.ico"
!define MUI_UNICON "..\..\Source\Resource\Image\MediaInfo.ico"

; Uninstaller signing
!uninstfinalize 'sign.cmd "%1" "MediaInfo Uninstaller"'

; Language Selection Dialog Settings
!define MUI_LANGDLL_REGISTRY_ROOT "${PRODUCT_UNINST_ROOT_KEY}"
Expand Down
4 changes: 4 additions & 0 deletions Source/Install/MediaInfo_GUI_Windows_i386.nsi
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ SetCompressor /FINAL /SOLID lzma
!include "MUI2.nsh"
!define MUI_ABORTWARNING
!define MUI_ICON "..\..\Source\Resource\Image\MediaInfo.ico"
!define MUI_UNICON "..\..\Source\Resource\Image\MediaInfo.ico"

; Uninstaller signing
!uninstfinalize 'sign.cmd "%1" "MediaInfo Uninstaller"'

; Language Selection Dialog Settings
!define MUI_LANGDLL_REGISTRY_ROOT "${PRODUCT_UNINST_ROOT_KEY}"
Expand Down
4 changes: 4 additions & 0 deletions Source/Install/MediaInfo_GUI_Windows_x64.nsi
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ SetCompressor /FINAL /SOLID lzma
!include "MUI2.nsh"
!define MUI_ABORTWARNING
!define MUI_ICON "..\..\Source\Resource\Image\MediaInfo.ico"
!define MUI_UNICON "..\..\Source\Resource\Image\MediaInfo.ico"

; Uninstaller signing
!uninstfinalize 'sign.cmd "%1" "MediaInfo Uninstaller"'

; Language Selection Dialog Settings
!define MUI_LANGDLL_REGISTRY_ROOT "${PRODUCT_UNINST_ROOT_KEY}"
Expand Down
5 changes: 5 additions & 0 deletions Source/Install/sign.cmd
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
set /P CodeSigningCertificatePass= < %USERPROFILE%\CodeSigningCertificate.pass
if "%NOSIGN%"=="" (
signtool.exe sign /f %USERPROFILE%\CodeSigningCertificate.p12 /p %CodeSigningCertificatePass% /fd sha256 /v /tr http://ts.ssl.com /td sha256 /d %2 /du http://mediaarea.net %1
)
set CodeSigningCertificatePass=

0 comments on commit 366729f

Please sign in to comment.