refactor console database #245
Conversation
EEPROM model is `SYSTEM246`
israpps
changed the title
| {0xd48f, "PX300-1", PS2TV, BLACK}, | ||
| {0xd490, "PX300-2", PS2TV, BLACK}, | ||
| {0xd491, "SCPH-90010 CR", 0, CINNABAR_RED}, // SM3 | ||
| {0x9000, "SYSTEM246 C", COH, BLACK}, |
There was a problem hiding this comment.
Actually, I don't like seeing here System 246/256. It seems that they dont have static value here, but instead it is part of their internal serial number. This means that other system246 will have a value that will differ a lot from 0x9000. You can make another PR once you confirm that other system246 always use 0x9000
There was a problem hiding this comment.
Are you 100% sure?
Remember we're missing 3 units including that one: 246C, 256, S256
There was a problem hiding this comment.
Not 100%, but about 90%, there few signs for it - structure does not meet Sony standarts, low and upper 8 bytes are identical, some nvram dumps doesnt have model name. This really requires more than one dump for making assumption, id rather assume that after COH-H30000 they dropped Sony standart support and just use pure SCMD mechacon commands for their internal purposes.
EEPROM model is
SYSTEM246Adding it here bc this is the only place where they're located...
I once thought of making the console ID detection code found here into a library for PS2SDK.