Add Cucumber features for Student viewpoint #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraglalbert
requested review from
PaulHooley,
susanmatuszewski and
emmaeagles
susanmatuszewski
approved these changes
Jan 20, 2020
kraglalbert
commented
Jan 20, 2020
| @@ -2,13 +2,10 @@ | |||
|
|
|||
There was a problem hiding this comment.
Formatting changes only in the first 3 files
susanmatuszewski
added a commit
that referenced
this pull request
Jan 22, 2020
* init start to implementing rest controller * init start to implementing rest controller * fixed infinite loop issue with DTOs * fixed creating double employers * fixed employer contact tests * changing lists to sets for some classes and fixed put request for employer contact * (#44, #46) code cleanup * Add Cucumber features for Student viewpoint (#55) * Implement Student and Coop service classes (#59) * WIP * Merging Susan changes * Format code * formatted code and resolved comments * init start to implementing rest controller * init start to implementing rest controller * fixed infinite loop issue with DTOs * fixed creating double employers * fixed employer contact tests * changing lists to sets for some classes and fixed put request for employer contact * (#44, #46) code cleanup * formatted code and resolved comments * fixed more merge conflicts Co-authored-by: Albert Kragl <[email protected]> Co-authored-by: Paul Hooley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added 3 feature files for the Student viewpoint:
Test Plan
mvn failsafe:integration-testand verified that all Cucumber feature files are run as expectedRelated Issues
#54