Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed update service methods and implemented cucumber tests #108

Merged
merged 16 commits into from
Feb 23, 2020
Merged

fixed update service methods and implemented cucumber tests #108

merged 16 commits into from
Feb 23, 2020

Conversation

susanmatuszewski
Copy link
Contributor

Summary

  • changed update methods to allow for null arguments, this way only necessary fields are updated
  • added more cucumber tests for admin and student
  • fixed bug with set and list pointers

Test Plan

mvn test, integration tests and cucumber tests

Related Issues

closes #95, part of #54

@kraglalbert kraglalbert self-requested a review February 21, 2020 21:44
kraglalbert
kraglalbert reviewed Feb 21, 2020
View reviewed changes
Copy link
Member

@kraglalbert kraglalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, some of them can be applied to multiple parts of this PR (like the loop break one) so keep an eye out for those

Backend/src/main/java/ca/mcgill/cooperator/controller/StudentReportController.java Outdated Show resolved Hide resolved
Backend/src/main/java/ca/mcgill/cooperator/service/AdminService.java Outdated Show resolved Hide resolved
Backend/src/main/java/ca/mcgill/cooperator/service/CoopDetailsService.java Outdated Show resolved Hide resolved
Backend/src/main/java/ca/mcgill/cooperator/service/CourseService.java Show resolved Hide resolved
Backend/src/main/java/ca/mcgill/cooperator/service/EmployerReportService.java Outdated Show resolved Hide resolved
Backend/src/main/java/ca/mcgill/cooperator/service/EmployerReportService.java Outdated Show resolved Hide resolved
Backend/src/main/java/ca/mcgill/cooperator/service/NotificationService.java Outdated Show resolved Hide resolved
Backend/src/test/java/ca/mcgill/cooperator/controller/StudentReportControllerIT.java Show resolved Hide resolved
@kraglalbert kraglalbert added backend A task/issue related to the backend fix labels Feb 21, 2020
kraglalbert
kraglalbert approved these changes Feb 23, 2020
View reviewed changes
Copy link
Member

@kraglalbert kraglalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor comments 🌮

Backend/src/main/java/ca/mcgill/cooperator/controller/StudentReportController.java Outdated Show resolved Hide resolved
Backend/src/main/java/ca/mcgill/cooperator/service/AdminService.java Outdated Show resolved Hide resolved
Backend/src/main/java/ca/mcgill/cooperator/service/CompanyService.java Outdated Show resolved Hide resolved
Backend/src/main/java/ca/mcgill/cooperator/service/EmployerContactService.java Outdated Show resolved Hide resolved
Backend/src/main/java/ca/mcgill/cooperator/service/StudentService.java Outdated Show resolved Hide resolved
Backend/src/test/java/ca/mcgill/cooperator/service/CooperatorServiceNotificationTests.java Outdated Show resolved Hide resolved
@susanmatuszewski susanmatuszewski merged commit 58c0837 into master Feb 23, 2020
@susanmatuszewski susanmatuszewski deleted the susan/cucumber-tests branch February 23, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraglalbert kraglalbert kraglalbert approved these changes

Assignees

@susanmatuszewski susanmatuszewski

Labels
backend A task/issue related to the backend fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix update methods to accept only parameters that should be updated
2 participants
@susanmatuszewski @kraglalbert